[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8054: Show headphone icons for devices identifying as "Headset" in Description
From:       Antonio Larrosa Jimenez <noreply () phabricator ! kde ! org>
Date:       2017-09-29 9:20:07
Message-ID: 20170929092007.107733.B0AEA764995431E2 () phabricator ! kde ! org
[Download RAW message or body]

antlarr added a comment.


  Note that the test for "headset" takes precedence with respect to the microphone, \
so for the capture device, now a headphone is shown instead of a microphone. I think \
it's more accurate (since it represents the microphone in the headset better than a \
microphone icon, which is also used for the internal soundcard microphone), but if \
that's not wanted, the test for "mic" could be moved upward.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D8054

To: antlarr, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">antlarr added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8054" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Note that the test for \
&quot;headset&quot; takes precedence with respect to the microphone, so for the \
capture device, now a headphone is shown instead of a microphone. I think it&#039;s \
more accurate (since it represents the microphone in the headset better than a \
microphone icon, which is also used for the internal soundcard microphone), but if \
that&#039;s not wanted, the test for &quot;mic&quot; could be moved \
upward.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R115 Plasma \
Audio Volume Applet</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a href="https://phabricator.kde.org/D8054" \
rel="noreferrer">https://phabricator.kde.org/D8054</a></div></div><br \
/><div><strong>To: </strong>antlarr, Plasma<br /><strong>Cc: </strong>plasma-devel, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, \
mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]