[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D7626: [CurrentContainmentActionsModel] Emit configurationChanged when action is added/removed/edite
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-08-31 12:42:15
Message-ID: differential-rev-PHID-DREV-mijvoqu6abx5r4xlnzjn-req () phabricator ! kde ! org
[Download RAW message or body]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Removes the need for the UI to explicitly do this on every action.

TEST PLAN
  Removed the manual invocations of `root.configurationChanged()` in \
`ConfigurationContainmentActions.qml` and adding, removing, changing actions enabled \
Apply button after I added a `Connections` for this signal

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7626

AFFECTED FILES
  shell/currentcontainmentactionsmodel.cpp

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">broulik created this revision.<br />Restricted Application \
added a project: Plasma.<br />Restricted Application added a subscriber: \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7626" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Removes \
the need for the UI to explicitly do this on every action.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>Removed the manual invocations of <tt \
style="background: #ebebeb; font-size: 13px;">root.configurationChanged()</tt> in <tt \
style="background: #ebebeb; font-size: \
13px;">ConfigurationContainmentActions.qml</tt> and adding, removing, changing \
actions enabled Apply button after I added a <tt style="background: #ebebeb; \
font-size: 13px;">Connections</tt> for this signal</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7626" \
rel="noreferrer">https://phabricator.kde.org/D7626</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>shell/currentcontainmentactionsmodel.cpp</div></div></div><br \
/><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, \
mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]