From kde-panel-devel  Thu Aug 31 12:42:15 2017
From: Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date: Thu, 31 Aug 2017 12:42:15 +0000
To: kde-panel-devel
Subject: D7626: [CurrentContainmentActionsModel] Emit configurationChanged when action is added/removed/edite
Message-Id: <differential-rev-PHID-DREV-mijvoqu6abx5r4xlnzjn-req () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=150418334730972
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--2a8feafdceb246f5b9794fef4d7a4b04"

--2a8feafdceb246f5b9794fef4d7a4b04
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Removes the need for the UI to explicitly do this on every action.

TEST PLAN
  Removed the manual invocations of `root.configurationChanged()` in `ConfigurationContainmentActions.qml` and adding, removing, changing actions enabled Apply button after I added a `Connections` for this signal

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7626

AFFECTED FILES
  shell/currentcontainmentactionsmodel.cpp

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

--2a8feafdceb246f5b9794fef4d7a4b04
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style=3D"">broulik created this revision.<br />Restricted Ap=
plication added a project: Plasma.<br />Restricted Application added a subs=
criber: plasma-devel.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D7626" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Removes th=
e need for the UI to explicitly do this on every action.</p></div></div><br=
 /><div><strong>TEST PLAN</strong><div><p>Removed the manual invocations of=
 <tt style=3D"background: #ebebeb; font-size: 13px;">root.configurationChan=
ged()</tt> in <tt style=3D"background: #ebebeb; font-size: 13px;">Configura=
tionContainmentActions.qml</tt> and adding, removing, changing actions enab=
led Apply button after I added a <tt style=3D"background: #ebebeb; font-siz=
e: 13px;">Connections</tt> for this signal</p></div></div><br /><div><stron=
g>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /=
><div><strong>REVISION DETAIL</strong><div><a href=3D"https://phabricator.k=
de.org/D7626" rel=3D"noreferrer">https://phabricator.kde.org/D7626</a></div=
></div><br /><div><strong>AFFECTED FILES</strong><div><div>shell/currentcon=
tainmentactionsmodel.cpp</div></div></div><br /><div><strong>To: </strong>b=
roulik, Plasma<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, =
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<b=
r /></div>
--2a8feafdceb246f5b9794fef4d7a4b04--