[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D7567: Support edit and appstream actions also for application search results
From: Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date: 2017-08-29 8:45:09
Message-ID: 20170829084509.101854.BCA6E16D62D80E37 () phabricator ! kde ! org
[Download RAW message or body]
broulik added a comment.
Minor nitpicks, then it's good to go.
INLINE COMMENTS
> actionlist.cpp:322
> +
> +bool canEdit(const QString &entryPath)
> +{
canEditApplication
> actionlist.cpp:327
> +
> +void edit(const QString &entryPath, const QString &menuId)
> +{
editApplication
> runnermatchesmodel.cpp:128
> + if (service->isApplication()) {
> + actionList << Kicker::createSeparatorActionItem();
> + actionList << Kicker::editApplicationAction(service);
You always add a separator at the end, so this isn't strictly neccessary (QMenu is \
smart enough to collapse double separators, though)
> backend.cpp:134
> +
> + if (launcherUrl.isValid() && launcherUrl.scheme() == \
> QStringLiteral("applications")) { + const KService::Ptr service = \
> KService::serviceByMenuId(launcherUrl.path());
Unrelated, from https://phabricator.kde.org/D7561?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D7567
To: hein, #plasma, broulik, davidedmundson
Cc: mak, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas
[Attachment #3 (unknown)]
<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7567" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Minor nitpicks, then it's good to \
go.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7567#inline-31032" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">actionlist.cpp:322</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">bool</span> <span \
class="n">canEdit</span><span class="p">(</span><span style="color: \
#aa4000">const</span> <span class="n">QString</span> <span style="color: \
#aa2211">&</span><span class="n">entryPath</span><span class="p">)</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"><span class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">canEditApplication</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D7567#inline-31031" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">actionlist.cpp:327</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">void</span> <span \
class="n">edit</span><span class="p">(</span><span style="color: \
#aa4000">const</span> <span class="n">QString</span> <span style="color: \
#aa2211">&</span><span class="n">entryPath</span><span class="p">,</span> <span \
style="color: #aa4000">const</span> <span class="n">QString</span> <span \
style="color: #aa2211">&</span><span class="n">menuId</span><span \
class="p">)</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"><span class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">editApplication</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D7567#inline-31030" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">runnermatchesmodel.cpp:128</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">if</span> <span class="p">(</span><span class="n">service</span><span \
style="color: #aa2211">-></span><span class="n">isApplication</span><span \
class="p">())</span> <span class="p">{</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">actionList</span> <span style="color: #aa2211"><<</span> <span \
class="n">Kicker</span><span style="color: #aa2211">::</span><span \
class="n">createSeparatorActionItem</span><span class="p">();</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span class="n">actionList</span> <span style="color: #aa2211"><<</span> <span \
class="n">Kicker</span><span style="color: #aa2211">::</span><span \
class="n">editApplicationAction</span><span class="p">(</span><span \
class="n">service</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You \
always add a separator at the end, so this isn't strictly neccessary (QMenu is \
smart enough to collapse double separators, though)</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D7567#inline-31029" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">backend.cpp:134</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(251, 175, 175, .7);"><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">||</span></span><span class="bright"> \
</span><span style="color: #aa2211"><span class="bright">!</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">KDesktopFile</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">::</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">isDesktopFile</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
class="n"><span class="bright">launcherUrl</span></span><span \
class="bright"></span><span class="p"><span class="bright">.</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">toLocalFile</span></span><span class="bright"></span><span \
class="p"><span class="bright">()))</span></span><span class="bright"> </span><span \
class="p"><span class="bright">{</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"> \
</span><span style="color: #aa4000"><span class="bright">return</span></span><span \
class="bright"> </span><span class="n"><span \
class="bright">actions</span></span><span class="bright"></span><span class="p"><span \
class="bright">;</span></span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> </div><div style="padding: 0 8px; margin: 0 \
4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span \
style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> \
</span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">launcherUrl</span></span><span class="bright"></span><span \
class="p"><span class="bright">.</span></span><span class="bright"></span><span \
class="n"><span class="bright">isValid</span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">&&</span></span><span \
class="bright"> </span><span class="n"><span \
class="bright">launcherUrl</span></span><span class="bright"></span><span \
class="p"><span class="bright">.</span></span><span class="bright"></span><span \
class="n"><span class="bright">scheme</span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">==</span></span><span class="bright"> \
</span><span class="n"><span class="bright">QStringLiteral</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span style="color: #766510"><span \
class="bright">"applications"</span></span><span \
class="bright"></span><span class="p"><span class="bright">))</span></span><span \
class="bright"> </span><span class="p"><span class="bright">{</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #aa4000">const</span> <span \
class="n">KService</span><span style="color: #aa2211">::</span><span \
class="n">Ptr</span> <span class="n">service</span> <span style="color: \
#aa2211">=</span> <span class="n">KService</span><span style="color: \
#aa2211">::</span><span class="n">serviceByMenuId</span><span class="p">(</span><span \
class="n">launcherUrl</span><span class="p">.</span><span class="n">path</span><span \
class="p">());</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Unrelated, from <a href="https://phabricator.kde.org/D7561" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" \
rel="noreferrer">D7561</a>?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7567" \
rel="noreferrer">https://phabricator.kde.org/D7567</a></div></div><br \
/><div><strong>To: </strong>hein, Plasma, broulik, davidedmundson<br /><strong>Cc: \
</strong>mak, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic