[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D7567: Support edit and appstream actions also for application search results
From:       Matthias Klumpp <noreply () phabricator ! kde ! org>
Date:       2017-08-28 19:46:32
Message-ID: 20170828194631.47696.A9912C6F0EA40F7C () phabricator ! kde ! org
[Download RAW message or body]

mak added inline comments.

INLINE COMMENTS

> hein wrote in actionlist.cpp:380
> That code wasn't touched during this refactoring, so this is immaterial to the \
> review. Please inform Aleix Pol about it.

I know, that's why I didn't flag this as change request (just a general observation).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7567

To: hein, #plasma, broulik, davidedmundson
Cc: mak, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">mak added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7567" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7567#inline-31014" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">hein</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">actionlist.cpp:380</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">That code wasn&#039;t touched \
during this refactoring, so this is immaterial to the review. Please inform Aleix Pol \
about it.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">I know, that&#039;s why I didn&#039;t flag this as \
change request (just a general observation).</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7567" \
rel="noreferrer">https://phabricator.kde.org/D7567</a></div></div><br \
/><div><strong>To: </strong>hein, Plasma, broulik, davidedmundson<br /><strong>Cc: \
</strong>mak, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]