[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D7155: Implement sorting of the device tree items
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-08-06 11:26:46
Message-ID: 20170806112645.78141.3C9B29B257BB4B38 () phabricator ! kde ! org
[Download RAW message or body]

broulik added inline comments.

INLINE COMMENTS

> devicelisting.cpp:49
> populateListing();   
> +    setSortingEnabled(true);
> }

Why disable again?

> soldevice.cpp:153
> +    const SolDevice * otherDevice = dynamic_cast<const SolDevice*>(&other);
> +    if (otherDevice != nullptr)
> +    {

Coding style: brace on the same line, also no need for explicit `nullptr` check:

  if (otherDevice) {

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7155

To: isaact, #plasma
Cc: broulik, anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7155" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7155#inline-29153" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">devicelisting.cpp:49</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; ">    <span class="n">populateListing</span><span class="p">();</span> \
 </div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">    <span class="n">setSortingEnabled</span><span class="p">(</span><span \
style="color: #304a96">true</span><span class="p">);</span> </div><div \
style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why \
disable again?</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D7155#inline-29152" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">soldevice.cpp:153</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> \
<span class="n">SolDevice</span> <span style="color: #aa2211">*</span> <span \
class="n">otherDevice</span> <span style="color: #aa2211">=</span> <span \
style="color: #aa4000">dynamic_cast</span><span style="color: \
#aa2211">&lt;</span><span style="color: #aa4000">const</span> <span \
class="n">SolDevice</span><span style="color: #aa2211">*&gt;</span><span \
class="p">(</span><span style="color: #aa2211">&amp;</span><span \
class="n">other</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: \
#aa4000">if</span> <span class="p">(</span><span class="n">otherDevice</span> <span \
style="color: #aa2211">!=</span> <span style="color: #aa4000">nullptr</span><span \
class="p">)</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Coding style: brace on the same line, also no need for explicit <tt \
style="background: #ebebeb; font-size: 13px;">nullptr</tt> check:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">if (otherDevice) \
{</pre></div></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7155" \
rel="noreferrer">https://phabricator.kde.org/D7155</a></div></div><br \
/><div><strong>To: </strong>isaact, Plasma<br /><strong>Cc: </strong>broulik, \
anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]