[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D7155: Implement sorting of the device tree items
From: Anthony Fieroni <noreply () phabricator ! kde ! org>
Date: 2017-08-06 3:40:29
Message-ID: 20170806034029.94823.35912BD021594CFD () phabricator ! kde ! org
[Download RAW message or body]
anthonyfieroni added a reviewer: Plasma.
anthonyfieroni added inline comments.
INLINE COMMENTS
> soldevice.cpp:165
> + const Solid::Processor *right = otherDevice->tiedDevice.as<const \
> Solid::Processor>(); + return left->number() > right->number();
> + }
left->number() < right->number() ?
> soldevice.cpp:169
> + {
> + return other.text(0) < text(0);
> + }
Reverse again ?
> soldevice.cpp:177
> +}
> \ No newline at end of file
Add a new line.
> soldevice.h:108
>
> + virtual bool operator< (const QTreeWidgetItem & other) const;
> protected:
Why virtual ?
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D7155
To: isaact, #plasma
Cc: anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas
[Attachment #3 (unknown)]
<table><tr><td style="">anthonyfieroni added a reviewer: Plasma.<br />anthonyfieroni \
added inline comments. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7155" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7155#inline-29145" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">soldevice.cpp:165</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">const</span> <span class="n">Solid</span><span style="color: \
#aa2211">::</span><span class="n">Processor</span> <span style="color: \
#aa2211">*</span><span class="n">right</span> <span style="color: #aa2211">=</span> \
<span class="n">otherDevice</span><span style="color: #aa2211">-></span><span \
class="n">tiedDevice</span><span class="p">.</span><span class="n">as</span><span \
style="color: #aa2211"><</span><span style="color: #aa4000">const</span> <span \
class="n">Solid</span><span style="color: #aa2211">::</span><span \
class="n">Processor</span><span style="color: #aa2211">></span><span \
class="p">();</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> \
<span class="n">left</span><span style="color: #aa2211">-></span><span \
class="n">number</span><span class="p">()</span> <span style="color: \
#aa2211">></span> <span class="n">right</span><span style="color: \
#aa2211">-></span><span class="n">number</span><span class="p">();</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">left->number() < right->number() ?</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D7155#inline-29147" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">soldevice.cpp:169</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #aa4000">return</span> <span class="n">other</span><span \
class="p">.</span><span class="n">text</span><span class="p">(</span><span \
style="color: #601200">0</span><span class="p">)</span> <span style="color: \
#aa2211"><</span> <span class="n">text</span><span class="p">(</span><span \
style="color: #601200">0</span><span class="p">);</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Reverse again ?</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D7155#inline-29146" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">soldevice.cpp:177</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"><span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Add \
a new line.</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D7155#inline-29144" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">soldevice.h:108</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> <span class="n">virtual</span> <span \
style="color: #aa4000">bool</span> <span class="n">operator</span><span style="color: \
#aa2211"><</span> <span class="p">(</span><span style="color: \
#aa4000">const</span> <span class="n">QTreeWidgetItem</span> <span style="color: \
#aa2211">&</span> <span class="n">other</span><span class="p">)</span> <span \
style="color: #aa4000">const</span><span class="p">;</span> </div><div \
style="padding: 0 8px; margin: 0 4px; "> <span style="color: \
#a0a000">protected</span><span class="p">:</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why \
virtual ?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7155" \
rel="noreferrer">https://phabricator.kde.org/D7155</a></div></div><br \
/><div><strong>To: </strong>isaact, Plasma<br /><strong>Cc: </strong>anthonyfieroni, \
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart, lukas<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic