[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6864: [System Monitor Applet] Add setting for update interval
From:       Christoph Feck <noreply () phabricator ! kde ! org>
Date:       2017-07-31 22:41:13
Message-ID: 20170731224111.68312.ED5110D5EA32FA63 () phabricator ! kde ! org
[Download RAW message or body]

cfeck added inline comments.

INLINE COMMENTS

> main.xml:13
> +    <entry name="updateInterval" type="Int">
> +        <label>The interval in milliseconds to update the data shown</label>
> +        <default>2000</default>

Add a "."

> ConfigGeneral.qml:115
> +                suffix: i18nc("Suffix for spinbox (seconds)", " sec")
> +                maximumValue: 1000
> +                stepSize: 0.5

Maybe it should also specify a minimum value, e.g. 0.05 sec. for 20 updates per \
second.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6864

To: broulik, #plasma
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">cfeck added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6864" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D6864#inline-28661" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">main.xml:13</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">    <span style="color: \
#00702a">&lt;entry</span> <span style="color: #354bb3">name=</span><span \
style="color: #766510">&quot;updateInterval&quot;</span> <span style="color: \
#354bb3">type=</span><span style="color: #766510">&quot;Int&quot;</span><span \
style="color: #00702a">&gt;</span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">        <span style="color: \
#00702a">&lt;label&gt;</span>The interval in milliseconds to update the data \
shown<span style="color: #00702a">&lt;/label&gt;</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: \
#00702a">&lt;default&gt;</span>2000<span style="color: \
#00702a">&lt;/default&gt;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Add \
a &quot;.&quot;</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D6864#inline-28662" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">ConfigGeneral.qml:115</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span \
style="color: #aa4000">suffix:</span> <span style="color: #004012">i18nc</span><span \
class="p">(</span><span style="color: #766510">&quot;Suffix for spinbox \
(seconds)&quot;</span><span class="p">,</span> <span style="color: #766510">&quot; \
sec&quot;</span><span class="p">)</span> </div><div style="padding: 0 8px; margin: 0 \
4px; background: rgba(151, 234, 151, .6);">                <span style="color: \
#aa4000">maximumValue:</span> <span style="color: #601200">1000</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">          \
<span style="color: #aa4000">stepSize:</span> <span style="color: #601200">0.5</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Maybe it should also specify a minimum value, e.g. 0.05 sec. for 20 \
updates per second.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6864" \
rel="noreferrer">https://phabricator.kde.org/D6864</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>cfeck, \
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]