--abddb300339b4a6385ac88212dcd1e81
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

cfeck added inline comments.

INLINE COMMENTS

> main.xml:13
> +    <entry name="updateInterval" type="Int">
> +        <label>The interval in milliseconds to update the data shown</label>
> +        <default>2000</default>

Add a "."

> ConfigGeneral.qml:115
> +                suffix: i18nc("Suffix for spinbox (seconds)", " sec")
> +                maximumValue: 1000
> +                stepSize: 0.5

Maybe it should also specify a minimum value, e.g. 0.05 sec. for 20 updates per second.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6864

To: broulik, #plasma
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

--abddb300339b4a6385ac88212dcd1e81
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style=3D"">cfeck added inline comments.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D6864" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style=3D"=
margin: 6px 0 12px 0;"><div style=3D"border: 1px solid #C7CCD9; border-radi=
us: 3px;"><div style=3D"padding: 0; background: #F7F7F7; border-color: #e3e=
4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style=
=3D"color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden=
;"><a style=3D"float: right; text-decoration: none;" href=3D"https://phabri=
cator.kde.org/D6864#inline-28661" rel=3D"noreferrer">View Inline</a><span s=
tyle=3D"color: #4b4d51; font-weight: bold;">main.xml:13</span></div>
<div style=3D"font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quo=
t;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px=
 0; margin: 0;"><div style=3D"padding: 0 8px; margin: 0 4px; background: rg=
ba(151, 234, 151, .6);">    <span style=3D"color: #00702a">&lt;entry</span>=
 <span style=3D"color: #354bb3">name=3D</span><span style=3D"color: #766510=
">&quot;updateInterval&quot;</span> <span style=3D"color: #354bb3">type=3D<=
/span><span style=3D"color: #766510">&quot;Int&quot;</span><span style=3D"c=
olor: #00702a">&gt;</span>
</div><div style=3D"padding: 0 8px; margin: 0 4px; background: rgba(151, 23=
4, 151, .6);">        <span style=3D"color: #00702a">&lt;label&gt;</span>Th=
e interval in milliseconds to update the data shown<span style=3D"color: #0=
0702a">&lt;/label&gt;</span>
</div><div style=3D"padding: 0 8px; margin: 0 4px; background: rgba(151, 23=
4, 151, .6);">        <span style=3D"color: #00702a">&lt;default&gt;</span>=
2000<span style=3D"color: #00702a">&lt;/default&gt;</span>
</div></div></div>
<div style=3D"margin: 8px 0; padding: 0 12px;"><p style=3D"padding: 0; marg=
in: 8px;">Add a &quot;.&quot;</p></div></div><br /><div style=3D"border: 1p=
x solid #C7CCD9; border-radius: 3px;"><div style=3D"padding: 0; background:=
 #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px=
 0; margin: 0;"><div style=3D"color: #74777d; background: #eff2f4; padding:=
 6px 8px; overflow: hidden;"><a style=3D"float: right; text-decoration: non=
e;" href=3D"https://phabricator.kde.org/D6864#inline-28662" rel=3D"noreferr=
er">View Inline</a><span style=3D"color: #4b4d51; font-weight: bold;">Confi=
gGeneral.qml:115</span></div>
<div style=3D"font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quo=
t;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px=
 0; margin: 0;"><div style=3D"padding: 0 8px; margin: 0 4px; background: rg=
ba(151, 234, 151, .6);">                <span style=3D"color: #aa4000">suff=
ix:</span> <span style=3D"color: #004012">i18nc</span><span class=3D"p">(</=
span><span style=3D"color: #766510">&quot;Suffix for spinbox (seconds)&quot=
;</span><span class=3D"p">,</span> <span style=3D"color: #766510">&quot; se=
c&quot;</span><span class=3D"p">)</span>
</div><div style=3D"padding: 0 8px; margin: 0 4px; background: rgba(151, 23=
4, 151, .6);">                <span style=3D"color: #aa4000">maximumValue:<=
/span> <span style=3D"color: #601200">1000</span>
</div><div style=3D"padding: 0 8px; margin: 0 4px; background: rgba(151, 23=
4, 151, .6);">                <span style=3D"color: #aa4000">stepSize:</spa=
n> <span style=3D"color: #601200">0.5</span>
</div></div></div>
<div style=3D"margin: 8px 0; padding: 0 12px;"><p style=3D"padding: 0; marg=
in: 8px;">Maybe it should also specify a minimum value, e.g. 0.05 sec. for =
20 updates per second.</p></div></div></div></div></div><br /><div><strong>=
REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><=
div><strong>REVISION DETAIL</strong><div><a href=3D"https://phabricator.kde=
.org/D6864" rel=3D"noreferrer">https://phabricator.kde.org/D6864</a></div><=
/div><br /><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </str=
ong>cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensr=
euterberg, abetts, sebas, apol, mart, lukas<br /></div>
--abddb300339b4a6385ac88212dcd1e81--