[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6933: [Component Chooser] Update http(s) scheme handler when changing default browser
From:       David Faure <noreply () phabricator ! kde ! org>
Date:       2017-07-29 5:56:04
Message-ID: 20170729055603.106807.80D74438DC19C4B6 () phabricator ! kde ! org
[Download RAW message or body]

dfaure added a comment.


  In https://phabricator.kde.org/D6933#129446, @broulik wrote:
  
  > > I suppose updating the handler for text/html would make sense too, so that \
clicking on a local HTML file opens the same webbrowser.  >
  > Well, KRun has a special case for text/html to always open them in the default \
browser, no matter what. So you cannot actually have Kate as your default app for \
HTML :D  
  
  Ah, I see. (comes from https://git.reviewboard.kde.org/r/103524). I think the \
reasoning was "after I set Firefox as my browser app, local HTML files still open in \
konqueror... bug!!! I shouldn't have to configure it twice".  But actually we get \
more flexibility if we don't mix up the two things. I.e. a user should be able to \
choose a browser *and* choose kate for local html files.  
  So I vote for
  
  1. setting the handler for text/html from here (if it's another BrowserApp)
  2. removing the text/html hack in KRun
  
  This way in the simple case, both HTTP and *.html open in your preferred browser,
  but for more advanced users it's still possible to open HTML files in something \
else.  
  PS: keditbookmarks shows up in the combo because it's been tagged WebBrowser, I \
guess for menu organization purposes. But it's not a webbrowser, so I'm not sure how \
to fix that...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6933

To: broulik, #plasma, dfaure
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">dfaure added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6933" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D6933#129446" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;" \
rel="noreferrer">D6933#129446</a>, <a href="https://phabricator.kde.org/p/broulik/" \
style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@broulik</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>I suppose updating the handler for text/html would \
make sense too, so that clicking on a local HTML file opens the same \
webbrowser.</p></blockquote>

<p>Well, KRun has a special case for text/html to always open them in the default \
browser, no matter what. So you cannot actually have Kate as your default app for \
HTML :D</p></div> </blockquote>

<p>Ah, I see. (comes from <a href="https://git.reviewboard.kde.org/r/103524" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://git.reviewboard.kde.org/r/103524</a>). I think the reasoning \
was &quot;after I set Firefox as my browser app, local HTML files still open in \
konqueror... bug!!! I shouldn&#039;t have to configure it twice&quot;.<br /> But \
actually we get more flexibility if we don&#039;t mix up the two things. I.e. a user \
should be able to choose a browser *and* choose kate for local html files.</p>

<p>So I vote for</p>

<ol class="remarkup-list">
<li class="remarkup-list-item">setting the handler for text/html from here (if \
it&#039;s another BrowserApp)</li> <li class="remarkup-list-item">removing the \
text/html hack in KRun</li> </ol>

<p>This way in the simple case, both HTTP and *.html open in your preferred \
browser,<br /> but for more advanced users it&#039;s still possible to open HTML \
files in something else.</p>

<p>PS: keditbookmarks shows up in the combo because it&#039;s been tagged WebBrowser, \
I guess for menu organization purposes. But it&#039;s not a webbrowser, so I&#039;m \
not sure how to fix that...</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6933" \
rel="noreferrer">https://phabricator.kde.org/D6933</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, dfaure<br /><strong>Cc: \
</strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]