[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6964: Force Plasma style for QQC2 in applets
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-07-28 15:17:23
Message-ID: 20170728151720.21705.0729ADB056E64098 () phabricator ! kde ! org
[Download RAW message or body]

mart added a comment.


  In https://phabricator.kde.org/D6964#129762, @davidedmundson wrote:
  
  > > ‎[13:51] ‎<‎notmart‎>‎ hmm, still random failures in loading \
components  > > ‎[13:58] ‎<‎notmart‎>‎ gaah, import of a subdirectory still \
breaks  >
  > Is this fixed?
  
  
  no, that's the problem of having to have a "private" subfolder in both themes i \
mentioned in the commit message, will need to look deeper in qml parsing to figure \
out what's going wrong and maybe patching qt, if both the style that we replace and \
the new one are controlled by us, that's workable around (as they happen to have the \
same directory structure) fragile but works  
  > Also we'll need to maybe look at changing how kirigami does its theme stuff so we \
can make that work.  
  kirigami does it exactly as qqc2 does, so should work as well. also in that case, \
we should make sure that both kirigami themes which we both control have the same \
directory structure

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6964

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">mart added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6964" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D6964#129762" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D6964#129762</a>, <a \
href="https://phabricator.kde.org/p/davidedmundson/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>‎[13:51] ‎&lt;‎notmart‎&gt;‎ hmm, still \
random failures in loading components<br /> ‎[13:58] ‎&lt;‎notmart‎&gt;‎ \
gaah, import of a subdirectory still breaks</p></blockquote>

<p>Is this fixed?</p></div>
</blockquote>

<p>no, that&#039;s the problem of having to have a &quot;private&quot; subfolder in \
both themes i mentioned in the commit message, will need to look deeper in qml \
parsing to figure out what&#039;s going wrong and maybe patching qt, if both the \
style that we replace and the new one are controlled by us, that&#039;s workable \
around (as they happen to have the same directory structure) fragile but works</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Also \
we&#039;ll need to maybe look at changing how kirigami does its theme stuff so we can \
make that work.</p></blockquote>

<p>kirigami does it exactly as qqc2 does, so should work as well. also in that case, \
we should make sure that both kirigami themes which we both control have the same \
directory structure</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6964" \
rel="noreferrer">https://phabricator.kde.org/D6964</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>davidedmundson, \
plasma-devel, Frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]