From kde-panel-devel  Fri Jul 28 15:17:23 2017
From: Marco Martin <noreply () phabricator ! kde ! org>
Date: Fri, 28 Jul 2017 15:17:23 +0000
To: kde-panel-devel
Subject: D6964: Force Plasma style for QQC2 in applets
Message-Id: <20170728151720.21705.0729ADB056E64098 () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=150125506126204
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--e40adbc18d82475db120020b769a48ed"

--e40adbc18d82475db120020b769a48ed
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0

mart added a comment.


  In https://phabricator.kde.org/D6964#129762, @davidedmundson wrote:
 =20
  > > =E2=80=8E[13:51] =E2=80=8E<=E2=80=8Enotmart=E2=80=8E>=E2=80=8E hmm, s=
till random failures in loading components
  > > =E2=80=8E[13:58] =E2=80=8E<=E2=80=8Enotmart=E2=80=8E>=E2=80=8E gaah, =
import of a subdirectory still breaks
  >
  > Is this fixed?
 =20
 =20
  no, that's the problem of having to have a "private" subfolder in both th=
emes i mentioned in the commit message, will need to look deeper in qml par=
sing to figure out what's going wrong and maybe patching qt, if both the st=
yle that we replace and the new one are controlled by us, that's workable a=
round (as they happen to have the same directory structure) fragile but wor=
ks
 =20
  > Also we'll need to maybe look at changing how kirigami does its theme s=
tuff so we can make that work.
 =20
  kirigami does it exactly as qqc2 does, so should work as well. also in th=
at case, we should make sure that both kirigami themes which we both contro=
l have the same directory structure

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6964

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezh=
ai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

--e40adbc18d82475db120020b769a48ed
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="utf-8"
Mime-Version: 1.0

<table><tr><td style=3D"">mart added a comment.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D6964" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><div><blockquote style=3D"border-left: 3px solid #8=
C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style=3D"font-style: normal;
          padding-bottom: 4px;">In <a href=3D"https://phabricator.kde.org/D=
6964#129762" style=3D"background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel=3D"noreferrer">D6964#129=
762</a>, <a href=3D"https://phabricator.kde.org/p/davidedmundson/" style=3D"
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel=3D"noreferrer">@davidedmundson</a> wro=
te:</div>
<div style=3D"margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style=3D"border-left: 3px=
 solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; p=
adding: 4px 12px; background-color: #f8f9fc;"><p>=E2=80=8E[13:51] =E2=80=8E=
&lt;=E2=80=8Enotmart=E2=80=8E&gt;=E2=80=8E hmm, still random failures in lo=
ading components<br />
=E2=80=8E[13:58] =E2=80=8E&lt;=E2=80=8Enotmart=E2=80=8E&gt;=E2=80=8E gaah, =
import of a subdirectory still breaks</p></blockquote>

<p>Is this fixed?</p></div>
</blockquote>

<p>no, that&#039;s the problem of having to have a &quot;private&quot; subf=
older in both themes i mentioned in the commit message, will need to look d=
eeper in qml parsing to figure out what&#039;s going wrong and maybe patchi=
ng qt, if both the style that we replace and the new one are controlled by =
us, that&#039;s workable around (as they happen to have the same directory =
structure) fragile but works</p>

<blockquote style=3D"border-left: 3px solid #a7b5bf; color: #464c5c; font-s=
tyle: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f=
8f9fc;"><p>Also we&#039;ll need to maybe look at changing how kirigami does=
 its theme stuff so we can make that work.</p></blockquote>

<p>kirigami does it exactly as qqc2 does, so should work as well. also in t=
hat case, we should make sure that both kirigami themes which we both contr=
ol have the same directory structure</p></div></div><br /><div><strong>REPO=
SITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><=
br /><div><strong>REVISION DETAIL</strong><div><a href=3D"https://phabricat=
or.kde.org/D6964" rel=3D"noreferrer">https://phabricator.kde.org/D6964</a><=
/div></div><br /><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </=
strong>davidedmundson, plasma-devel, Frameworks, ZrenBot, progwolff, leslie=
zhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></=
div>
--e40adbc18d82475db120020b769a48ed--