[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6403: get rid of manual window flags setting on controller
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-06-30 17:23:12
Message-ID: 20170630172253.123185.97B169DBB0DCBA1B () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> mart wrote in panelconfigview.cpp:69
> note: removing the whole line seems to be necessary as seems that setting any flag does break \
> focus

I can see why it would break KeepAbove.

QXcbWindow::setWindowFlags explicitly sets setNetWmStateWindowFlags without reading it from the \
window first.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6403

To: mart, #plasma, davidedmundson
Cc: mvourlakos, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson added inline \
comments.<br />This revision is now accepted and ready to land. </td><a style="text-decoration: \
none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6403" rel="noreferrer">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: \
#F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D6403#inline-26617" rel="noreferrer">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">mart</span> wrote in <span style="color: #4b4d51; \
font-weight: bold;">panelconfigview.cpp:69</span></div> <div style="margin: 8px 0; padding: 0 \
12px; color: #74777D;"><p style="padding: 0; margin: 8px;">note: removing the whole line seems \
to be necessary as seems that setting any flag does break focus</p></div></div> <div \
style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I can see why it \
would break KeepAbove.</p>

<p style="padding: 0; margin: 8px;">QXcbWindow::setWindowFlags explicitly sets \
setNetWmStateWindowFlags without reading it from the window \
first.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 \
Plasma Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a href="https://phabricator.kde.org/D6403" \
rel="noreferrer">https://phabricator.kde.org/D6403</a></div></div><br /><div><strong>To: \
</strong>mart, Plasma, davidedmundson<br /><strong>Cc: </strong>mvourlakos, davidedmundson, \
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, \
mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]