From kde-panel-devel  Fri Jun 30 17:23:12 2017
From: David Edmundson <noreply () phabricator ! kde ! org>
Date: Fri, 30 Jun 2017 17:23:12 +0000
To: kde-panel-devel
Subject: D6403: get rid of manual window flags setting on controller
Message-Id: <20170630172253.123185.97B169DBB0DCBA1B () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=149884340724865
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--411ce8329a3e4f22a39b36e0313d12a5"

--411ce8329a3e4f22a39b36e0313d12a5
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> mart wrote in panelconfigview.cpp:69
> note: removing the whole line seems to be necessary as seems that setting any flag does break focus

I can see why it would break KeepAbove.

QXcbWindow::setWindowFlags explicitly sets setNetWmStateWindowFlags without reading it from the window first.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6403

To: mart, #plasma, davidedmundson
Cc: mvourlakos, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

--411ce8329a3e4f22a39b36e0313d12a5
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style=3D"">davidedmundson accepted this revision.<br />david=
edmundson added inline comments.<br />This revision is now accepted and rea=
dy to land.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D6403" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style=3D"=
margin: 6px 0 12px 0;"><div style=3D"border: 1px solid #C7CCD9; border-radi=
us: 3px;"><div style=3D"padding: 0; background: #F7F7F7; border-color: #e3e=
4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style=
=3D"color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden=
;"><a style=3D"float: right; text-decoration: none;" href=3D"https://phabri=
cator.kde.org/D6403#inline-26617" rel=3D"noreferrer">View Inline</a><span s=
tyle=3D"color: #4b4d51; font-weight: bold;">mart</span> wrote in <span styl=
e=3D"color: #4b4d51; font-weight: bold;">panelconfigview.cpp:69</span></div>
<div style=3D"margin: 8px 0; padding: 0 12px; color: #74777D;"><p style=3D"=
padding: 0; margin: 8px;">note: removing the whole line seems to be necessa=
ry as seems that setting any flag does break focus</p></div></div>
<div style=3D"margin: 8px 0; padding: 0 12px;"><p style=3D"padding: 0; marg=
in: 8px;">I can see why it would break KeepAbove.</p>

<p style=3D"padding: 0; margin: 8px;">QXcbWindow::setWindowFlags explicitly=
 sets setNetWmStateWindowFlags without reading it from the window first.</p=
></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><=
div>R120 Plasma Workspace</div></div></div><br /><div><strong>BRANCH</stron=
g><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</str=
ong><div><a href=3D"https://phabricator.kde.org/D6403" rel=3D"noreferrer">h=
ttps://phabricator.kde.org/D6403</a></div></div><br /><div><strong>To: </st=
rong>mart, Plasma, davidedmundson<br /><strong>Cc: </strong>mvourlakos, dav=
idedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jen=
sreuterberg, abetts, sebas, apol, mart, lukas<br /></div>
--411ce8329a3e4f22a39b36e0313d12a5--