[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6455: position the shellsurface immediately
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-06-30 16:00:18
Message-ID: differential-rev-PHID-DREV-7cqtbrhhnubamuvmhn6b-req () phabricator ! kde ! org
[Download RAW message or body]

mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  when the window gets moved, position the shellsurface immediately
  rather than in an event: otherwise it's too late and having a moment
  in which the geometry doesn't correspond with the actual surface
  geometry, makes the panelcontroller window to stutter and tremble
  while dragged around with wayland

TEST PLAN
  dragging panel controller around on wayland is more deterministic,
  tough it's kinda slow, while dragging it with the touchscreen instead
  of a mouse or touchpad is as fast as expected, this may be worth
  further investigation (a kwin issue?)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6455

AFFECTED FILES
  shell/panelconfigview.cpp
  shell/panelconfigview.h

To: mart, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">mart created this revision.<br />Restricted Application added \
a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6455" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>when the \
window gets moved, position the shellsurface immediately<br /> rather than in an \
event: otherwise it&#039;s too late and having a moment<br /> in which the geometry \
doesn&#039;t correspond with the actual surface<br /> geometry, makes the \
panelcontroller window to stutter and tremble<br /> while dragged around with \
wayland</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>dragging panel \
controller around on wayland is more deterministic,<br /> tough it&#039;s kinda slow, \
while dragging it with the touchscreen instead<br /> of a mouse or touchpad is as \
fast as expected, this may be worth<br /> further investigation (a kwin \
issue?)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6455" \
rel="noreferrer">https://phabricator.kde.org/D6455</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>shell/panelconfigview.cpp<br /> \
shell/panelconfigview.h</div></div></div><br /><div><strong>To: </strong>mart, \
Plasma<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]