[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6403: get rid of manual window flags setting on controller
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-06-30 15:06:04
Message-ID: 20170630150551.1124.3E663417746B5ACC () phabricator ! kde ! org
[Download RAW message or body]

mart added inline comments.

INLINE COMMENTS

> panelconfigview.cpp:69
> KWindowSystem::setState(winId(), NET::KeepAbove);
> -    setFlags(Qt::WindowFlags((flags() | Qt::FramelessWindowHint | \
> Qt::WindowStaysOnTopHint) & (~Qt::WindowDoesNotAcceptFocus))); \
> KWindowSystem::forceActiveWindow(winId());

note: removing the whole line seems to be necessary as seems that setting any flag \
does break focus

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6403

To: mart, #plasma
Cc: mvourlakos, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6403" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D6403#inline-26617" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">panelconfigview.cpp:69</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; ">    <span class="n">KWindowSystem</span><span style="color: \
#aa2211">::</span><span class="n">setState</span><span class="p">(</span><span \
class="n">winId</span><span class="p">(),</span> <span class="n">NET</span><span \
style="color: #aa2211">::</span><span class="n">KeepAbove</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(251, 175, 175, .7);">    <span class="n">setFlags</span><span \
class="p">(</span><span class="n">Qt</span><span style="color: \
#aa2211">::</span><span class="n">WindowFlags</span><span class="p">((</span><span \
class="n">flags</span><span class="p">()</span> <span style="color: #aa2211">|</span> \
<span class="n">Qt</span><span style="color: #aa2211">::</span><span \
class="n">FramelessWindowHint</span> <span style="color: #aa2211">|</span> <span \
class="n">Qt</span><span style="color: #aa2211">::</span><span \
class="n">WindowStaysOnTopHint</span><span class="p">)</span> <span style="color: \
#aa2211">&amp;</span> <span class="p">(</span><span style="color: \
#aa2211">~</span><span class="n">Qt</span><span style="color: #aa2211">::</span><span \
class="n">WindowDoesNotAcceptFocus</span><span class="p">)));</span> </div><div \
style="padding: 0 8px; margin: 0 4px; ">    <span class="n">KWindowSystem</span><span \
style="color: #aa2211">::</span><span class="n">forceActiveWindow</span><span \
class="p">(</span><span class="n">winId</span><span class="p">());</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">note: removing the whole line seems to be necessary as seems that \
setting any flag does break focus</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6403" \
rel="noreferrer">https://phabricator.kde.org/D6403</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>mvourlakos, \
davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]