[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6440: [CurrentContainmentActionsModel] Allow making the action about dialog modal
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-06-30 8:50:42
Message-ID: 20170630085042.24449.6A304513442490E1 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added a comment.


  I would expect either:
  
  if (ctx)
  else {
  
    // do what the old code did
  
  }
  
  or to be changing a bunch of QML code somewhere.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6440

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6440" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>I would expect either:</p>

<p>if (ctx)<br />
else {</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">// do what the old code \
did</pre></div>

<p>}</p>

<p>or to be changing a bunch of QML code somewhere.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6440" \
rel="noreferrer">https://phabricator.kde.org/D6440</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>davidedmundson, \
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]