[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6440: [CurrentContainmentActionsModel] Allow making the action about dialog modal
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-06-30 8:16:06
Message-ID: differential-rev-PHID-DREV-wiydntjlostqqyjgt7np-req () phabricator ! kde ! org
[Download RAW message or body]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This adjusts the "configure" dialog in the same way as the "about" dialog I fixed \
in https://phabricator.kde.org/R120:2f66c0d11c68f13dd81d6a941d4ee95a63d4bdfe

TEST PLAN
  Changed the code in ConfigurationContainmentAction to pass `this` (ie. the button \
you clicked) along and then the window was modal to the config dialog, no exec \
involved.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6440

AFFECTED FILES
  shell/currentcontainmentactionsmodel.cpp
  shell/currentcontainmentactionsmodel.h

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">broulik created this revision.<br />Restricted Application \
added a project: Plasma.<br />Restricted Application added a subscriber: \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6440" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This \
adjusts the &quot;configure&quot; dialog in the same way as the &quot;about&quot; \
dialog I fixed in <a \
href="https://phabricator.kde.org/R120:2f66c0d11c68f13dd81d6a941d4ee95a63d4bdfe" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" \
rel="noreferrer">2f66c0d11c68f13dd81d6a941d4ee95a63d4bdfe</a></p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>Changed the code in \
ConfigurationContainmentAction to pass <tt style="background: #ebebeb; font-size: \
13px;">this</tt> (ie. the button you clicked) along and then the window was modal to \
the config dialog, no exec involved.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6440" \
rel="noreferrer">https://phabricator.kde.org/D6440</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>shell/currentcontainmentactionsmodel.cpp<br /> \
shell/currentcontainmentactionsmodel.h</div></div></div><br /><div><strong>To: \
</strong>broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]