[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6047: WIP: Support XDG v6
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-06-20 9:55:37
Message-ID: 20170620095537.70206.726F10C65DDAE4FA () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson updated this revision to Diff 15634.
davidedmundson edited the summary of this revision.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6047?vs=15020&id=15634

REVISION DETAIL
  https://phabricator.kde.org/D6047

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_shell.cpp
  autotests/client/test_xdg_shell.h
  autotests/client/test_xdg_shell_v5.cpp
  autotests/client/test_xdg_shell_v6.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-shell-unstable-v6.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgshell.cpp
  src/client/xdgshell.h
  src/client/xdgshell_p.h
  src/client/xdgshell_v5.cpp
  src/client/xdgshell_v6.cpp
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/xdgshell_interface.cpp
  src/server/xdgshell_interface.h
  src/server/xdgshell_interface_p.h
  src/server/xdgshell_v5_interface.cpp
  src/server/xdgshell_v5_interface_p.h
  src/server/xdgshell_v6_interface.cpp
  src/server/xdgshell_v6_interface_p.h
  src/tools/mapping.txt
  tests/CMakeLists.txt
  tests/xdgtest.cpp

To: davidedmundson, #plasma
Cc: mart, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson updated this revision to Diff 15634.<br \
/>davidedmundson edited the summary of this revision. <a \
href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-sdwq6z4xpe33yld/" \
rel="noreferrer">(Show Details)</a> </td><a style="text-decoration: none; padding: \
4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6047" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>CHANGES TO REVISION \
SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div \
style="padding: 8px 0;">...</div>The server only announced it has a new \
&quot;XdgSurface&quot; when it gets a new zxdg_surface_get_toplevel.<br /> <br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, \
.7);">Don&#039;t write comments about popup code not being implemented...</span><span \
style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">----<br \
/> <br />
Popup decisions:<br />
 - On popup creation the server should copy the current info from the positioner and \
then it gets deleted. Given kwaylands job is to keep state, we expose all these \
parameter via popup.<br /> <br />
 - Due to this positioner is not exposed as a resource anywhere.<br />
<br />
 - Server API is 100% backwards compatiable.<br />
i.e new code will work identically with v5 clients.<br />
<br />
 - Client API is not.  Grabs are called separately from the constructor, and the \
parent surface changed to an xdgsurface, not a raw surface.<br /> V5 code still works \
as-is, just not with the new constructors.<br />  <br />
It seemed better to match the v6 (and what will be the stable v7) than to try and do \
hacks and lose functionality.<br /> Given the client needs to change the code to opt \
into V6 anyway. I don&#039;t think this is a huge problem.<br /> \
</span></div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a \
href="https://phabricator.kde.org/D6047?vs=15020&amp;id=15634" \
rel="noreferrer">https://phabricator.kde.org/D6047?vs=15020&amp;id=15634</a></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6047" \
rel="noreferrer">https://phabricator.kde.org/D6047</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>autotests/client/CMakeLists.txt<br /> \
autotests/client/test_xdg_shell.cpp<br /> autotests/client/test_xdg_shell.h<br />
autotests/client/test_xdg_shell_v5.cpp<br />
autotests/client/test_xdg_shell_v6.cpp<br />
src/client/CMakeLists.txt<br />
src/client/protocols/xdg-shell-unstable-v6.xml<br />
src/client/registry.cpp<br />
src/client/registry.h<br />
src/client/xdgshell.cpp<br />
src/client/xdgshell.h<br />
src/client/xdgshell_p.h<br />
src/client/xdgshell_v5.cpp<br />
src/client/xdgshell_v6.cpp<br />
src/server/CMakeLists.txt<br />
src/server/display.cpp<br />
src/server/xdgshell_interface.cpp<br />
src/server/xdgshell_interface.h<br />
src/server/xdgshell_interface_p.h<br />
src/server/xdgshell_v5_interface.cpp<br />
src/server/xdgshell_v5_interface_p.h<br />
src/server/xdgshell_v6_interface.cpp<br />
src/server/xdgshell_v6_interface_p.h<br />
src/tools/mapping.txt<br />
tests/CMakeLists.txt<br />
tests/xdgtest.cpp</div></div></div><br /><div><strong>To: </strong>davidedmundson, \
Plasma<br /><strong>Cc: </strong>mart, plasma-devel, Frameworks, ZrenBot, spstarr, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]