[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D6047: WIP: Support XDG v6
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-06-05 11:25:41
Message-ID: 20170605112540.81322.6113C39A48C857C9 () phabricator ! kde ! org
[Download RAW message or body]

mart added inline comments.

INLINE COMMENTS

> mart wrote in xdgshell_interface.h:80
> so storing all the ids of pings in progress somewhere to make a more recent ping \
> not cancel an older one still pending?

from kwin, client.cpp:
i guess that's the kwin part that will have to use this.
it uses a single timer, and tries for a couple of timeout, as soon as the client \
answers it's considered good, no serial for pings is considered.

void Client::pingWindow()
{

  if (!info->supportsProtocol(NET::PingProtocol))
      return; // Can't ping :(
  if (options->killPingTimeout() == 0)
      return; // Turned off
  if (ping_timer != NULL)
      return; // Pinging already
  ping_timer = new QTimer(this);
  connect(ping_timer, &QTimer::timeout, this,
      [this]() {
          if (unresponsive()) {
              qCDebug(KWIN_CORE) << "Final ping timeout, asking to kill:" << \
caption();  ping_timer->deleteLater();
              ping_timer = nullptr;
              killProcess(true, m_pingTimestamp);
              return;
          }
  
          qCDebug(KWIN_CORE) << "First ping timeout:" << caption();
  
          setUnresponsive(true);
          ping_timer->start();
      }
  );

REVISION DETAIL
  https://phabricator.kde.org/D6047

To: davidedmundson, #plasma
Cc: mart, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6047" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D6047#inline-24878" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">mart</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">xdgshell_interface.h:80</span></div> <div style="margin: 8px 0; padding: 0 \
12px; color: #74777D;"><p style="padding: 0; margin: 8px;">so storing all the ids of \
pings in progress somewhere to make a more recent ping not cancel an older one still \
pending?</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">from kwin, client.cpp:<br /> i guess that&#039;s the \
kwin part that will have to use this.<br /> it uses a single timer, and tries for a \
couple of timeout, as soon as the client answers it&#039;s considered good, no serial \
for pings is considered.</p>

<p style="padding: 0; margin: 8px;">void Client::pingWindow()<br />
{</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">if \
(!info-&gt;supportsProtocol(NET::PingProtocol))  return; // Can&#039;t ping :(
if (options-&gt;killPingTimeout() == 0)
    return; // Turned off
if (ping_timer != NULL)
    return; // Pinging already
ping_timer = new QTimer(this);
connect(ping_timer, &amp;QTimer::timeout, this,
    [this]() {
        if (unresponsive()) {
            qCDebug(KWIN_CORE) &lt;&lt; &quot;Final ping timeout, asking to \
kill:&quot; &lt;&lt; caption();  ping_timer-&gt;deleteLater();
            ping_timer = nullptr;
            killProcess(true, m_pingTimestamp);
            return;
        }

        qCDebug(KWIN_CORE) &lt;&lt; &quot;First ping timeout:&quot; &lt;&lt; \
caption();

        setUnresponsive(true);
        ping_timer-&gt;start();
    }
);</pre></div></div></div></div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a href="https://phabricator.kde.org/D6047" \
rel="noreferrer">https://phabricator.kde.org/D6047</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>mart, \
plasma-devel, Frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]