[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6273: [tabbox] Fix casts to Client where it should be AbstractClient
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2017-06-19 15:09:37
Message-ID: differential-rev-PHID-DREV-m2ndo3wlc742nggzklj2-req () phabricator ! kde ! org
[Download RAW message or body]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  A few areas in TabBox perform casts from Toplevel to Client. By casting
  to Client instead of AbstractClient the Wayland windows are excluded.
  
  This change addresses the problem by changing the casts where possible.
  The only remaining cast to Client is for shading which is not (yet)
  supported for Wayland windows anyway.

REPOSITORY
  R108 KWin

BRANCH
  fix-tabbox-wayland-client-5.10

REVISION DETAIL
  https://phabricator.kde.org/D6273

AFFECTED FILES
  tabbox/tabbox.cpp
  tabbox/tabbox.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin created this revision.<br />Restricted Application \
added a project: KWin.<br />Restricted Application added subscribers: kwin, \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6273" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>A few \
areas in TabBox perform casts from Toplevel to Client. By casting<br /> to Client \
instead of AbstractClient the Wayland windows are excluded.</p>

<p>This change addresses the problem by changing the casts where possible.<br />
The only remaining cast to Client is for shading which is not (yet)<br />
supported for Wayland windows anyway.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>fix-tabbox-wayland-client-5.10</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6273" \
rel="noreferrer">https://phabricator.kde.org/D6273</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>tabbox/tabbox.cpp<br /> \
tabbox/tabbox.h</div></div></div><br /><div><strong>To: </strong>graesslin, KWin, \
Plasma<br /><strong>Cc: </strong>plasma-devel, kwin, ZrenBot, spstarr, progwolff, \
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, \
lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]