[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 130163: Add ConsoleKit2 support for launching Wayland sessions
From: Martin_Flöser <mgraesslin () kde ! org>
Date: 2017-06-19 14:49:19
Message-ID: 20170619144919.30813.80630 () mimi ! kde ! org
[Download RAW message or body]
--===============7920322856512594883==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130163/#review103347
-----------------------------------------------------------
We are currently in the process of fading out reviewboard. Could you please reopen \
the request on phabricator.kde.org in order to reach all developers. Not everyone is \
looking at reviewboard any more.
Thank you!
- Martin Flöser
On June 19, 2017, 9:42 a.m., Eric Koegel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130163/
> -----------------------------------------------------------
>
> (Updated June 19, 2017, 9:42 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kwin
>
>
> Description
> -------
>
> ConsoleKit2 as of version 1.1.1 implements the Session Controller dbus calls \
> required by Kwin to run under Wayland. This patch first looks for the login1 \
> service before attempting the ConsoleKit service.
>
> Diffs
> -----
>
> logind.h 8bb0206
> logind.cpp fee0f2f
>
> Diff: https://git.reviewboard.kde.org/r/130163/diff/
>
>
> Testing
> -------
>
> On a system running ConsoleKit2, logging into a text console and running:
> ```
> export $(dbus-launch); export QT_QPA_PLATFORM=wayland; startplasmacompositor
> ```
> Most of this patch is just shuffling code around to support both logind and CK2.
>
>
> Thanks,
>
> Eric Koegel
>
>
--===============7920322856512594883==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130163/">https://git.reviewboard.kde.org/r/130163/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We \
are currently in the process of fading out reviewboard. Could you please reopen the \
request on phabricator.kde.org in order to reach all developers. Not everyone is \
looking at reviewboard any more.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Thank you!</p></pre> \
<br />
<p>- Martin Flöser</p>
<br />
<p>On June 19th, 2017, 9:42 a.m. CEST, Eric Koegel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Eric Koegel.</div>
<p style="color: grey;"><i>Updated June 19, 2017, 9:42 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">ConsoleKit2 as of version 1.1.1 implements the Session \
Controller dbus calls required by Kwin to run under Wayland. This patch first looks \
for the login1 service before attempting the ConsoleKit service.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On a system running ConsoleKit2, logging into a text \
console and running:</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;"><div class="codehilite" \
style="background: #f8f8f8"><pre style="line-height: 125%"><span></span>export \
$(dbus-launch); export QT_QPA_PLATFORM=wayland; startplasmacompositor </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Most of this patch is just shuffling code around to \
support both logind and CK2.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>logind.h <span style="color: grey">(8bb0206)</span></li>
<li>logind.cpp <span style="color: grey">(fee0f2f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130163/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7920322856512594883==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic