[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5262: Animate quick tiling outline
From:       Martin_Gräßlin <noreply () phabricator ! kde ! org>
Date:       2017-03-31 14:58:18
Message-ID: 20170331145818.34306.49221.6EE3CAD8 () phabricator ! kde ! org
[Download RAW message or body]

graesslin added inline comments.

INLINE COMMENTS

> geometry.cpp:3257
> if (maximizing)
> -        outline()->show(electricBorderMaximizeGeometry(Cursor::pos(), desktop()));
> +        outline()->show(electricBorderMaximizeGeometry(Cursor::pos(), desktop()), geometry());
> else

I'm not sure whether geometry() always provides the correct geometry you want to have. I think \
moveResizeGeometry() would be the better choice here.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5262

To: broulik, #plasma, #kwin, #vdg
Cc: graesslin, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, \
sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">graesslin added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; \
font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5262" rel="noreferrer">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: \
#eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D5262#inline-21688" rel="noreferrer">View Inline</a><span style="color: \
#4b4d51; font-weight: bold;">geometry.cpp:3257</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: \
#aa4000">if</span> <span class="p">(</span><span class="n">maximizing</span><span class="p">)</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span \
class="n">outline</span><span class="p">()</span><span style="color: #aa2211">-&gt;</span><span \
class="n">show</span><span class="p">(</span><span class="n">electricBorderMaximizeGeometry</span><span \
class="p">(</span><span class="n">Cursor</span><span style="color: #aa2211">::</span><span \
class="n">pos</span><span class="p">(),</span> <span class="n">desktop</span><span class="p">()));</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span \
class="n">outline</span><span class="p">()</span><span style="color: #aa2211">-&gt;</span><span \
class="n">show</span><span class="p">(</span><span class="n">electricBorderMaximizeGeometry</span><span \
class="p">(</span><span class="n">Cursor</span><span style="color: #aa2211">::</span><span \
class="n">pos</span><span class="p">(),</span> <span class="n">desktop</span><span class="p">())<span \
class="bright">,</span></span><span class="bright"> </span><span class="n"><span \
class="bright">geometry</span></span><span class="bright"></span><span class="p"><span \
class="bright">()</span>);</span> </div><div style="padding: 0 8px; margin: 0 4px; ">    <span \
style="color: #aa4000">else</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I&#039;m not sure \
whether geometry() always provides the correct geometry you want to have. I think moveResizeGeometry() \
would be the better choice here.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a href="https://phabricator.kde.org/D5262" \
rel="noreferrer">https://phabricator.kde.org/D5262</a></div></div><br /><div><strong>To: \
</strong>broulik, Plasma, KWin, VDG<br /><strong>Cc: </strong>graesslin, plasma-devel, kwin, progwolff, \
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]