From kde-panel-devel Fri Mar 31 14:58:18 2017 From: =?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?= Date: Fri, 31 Mar 2017 14:58:18 +0000 To: kde-panel-devel Subject: D5262: Animate quick tiling outline Message-Id: <20170331145818.34306.49221.6EE3CAD8 () phabricator ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=149097232207569 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--c1454d641561452b8fa6320ae41bf315" --c1454d641561452b8fa6320ae41bf315 Content-Type: text/plain; charset="ascii" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit graesslin added inline comments. INLINE COMMENTS > geometry.cpp:3257 > if (maximizing) > - outline()->show(electricBorderMaximizeGeometry(Cursor::pos(), desktop())); > + outline()->show(electricBorderMaximizeGeometry(Cursor::pos(), desktop()), geometry()); > else I'm not sure whether geometry() always provides the correct geometry you want to have. I think moveResizeGeometry() would be the better choice here. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5262 To: broulik, #plasma, #kwin, #vdg Cc: graesslin, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol --c1454d641561452b8fa6320ae41bf315 Content-Type: text/html; charset="ascii" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable View Revision=
graesslin added inline comments.

INLINE COMMENTS
if (maximizing)
outline()<= /span>->show(electricBorderMaximizeGeomet= ry(Cursor::pos(), desktop()));
outline()<= /span>->show(electricBorderMaximizeGeomet= ry(Cursor::pos(), desktop()), geometry());
else

I'm not sure whether geometry() always provides the correct = geometry you want to have. I think moveResizeGeometry() would be the better= choice here.


REPOSITOR= Y
R108 KWin

REVISION = DETAIL
https://phabricator.kde.org/D5262

To: broulik, Plasma, KWin, VDG
Cc: graess= lin, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, jen= sreuterberg, abetts, sebas, apol
--c1454d641561452b8fa6320ae41bf315--