[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D3805: Per-activity favorites (WIP)
From:       Ivan Čukić <noreply () phabricator ! kde ! org>
Date:       2017-02-28 21:32:04
Message-ID: 20170228213204.77647.74252.9D95CD09 () phabricator ! kde ! org
[Download RAW message or body]

ivan added a comment.


  There are a few problems regarding the 'drop' placeholder needed for the Dashboard:
  
  - The placeholder is handled by the model which is a bit hackish, but this can \
mostly work for the new model as well by using the same offset-items-by-one trick \
                used in the original model
  - The model can set the ordering for the items in it only when the item is there, \
so in order for this to work, the model needs to wait for the item to appear, and \
then move it to the desired position  
  Both of these I have done, but that part is quite ugly. If this is considered a \
**necessary** feature, I can post the updated diff for review.

REVISION DETAIL
  https://phabricator.kde.org/D3805

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, mart, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol


[Attachment #3 (text/html)]

<table><tr><td style="">ivan added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3805" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>There are a few problems regarding the \
&#039;drop&#039; placeholder needed for the Dashboard:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">The placeholder is handled by the model which is a bit \
hackish, but this can mostly work for the new model as well by using the same \
offset-items-by-one trick used in the original model</li> <li \
class="remarkup-list-item">The model can set the ordering for the items in it only \
when the item is there, so in order for this to work, the model needs to wait for the \
item to appear, and then move it to the desired position</li> </ul>

<p>Both of these I have done, but that part is quite ugly. If this is considered a \
<strong>necessary</strong> feature, I can post the updated diff for \
review.</p></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3805" \
rel="noreferrer">https://phabricator.kde.org/D3805</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>ivan, mart, hein<br /><strong>Cc: </strong>plasma-devel, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]