From kde-panel-devel  Tue Feb 28 21:32:04 2017
From: =?utf-8?b?SXZhbiDEjHVracSH?= <noreply () phabricator ! kde ! org>
Date: Tue, 28 Feb 2017 21:32:04 +0000
To: kde-panel-devel
Subject: [Differential] [Commented On] D3805: Per-activity favorites (WIP)
Message-Id: <20170228213204.77647.74252.9D95CD09 () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=148831753808737
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--1393aeaf1ac946dcbd0ed1f83c517593"

--1393aeaf1ac946dcbd0ed1f83c517593
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

ivan added a comment.


  There are a few problems regarding the 'drop' placeholder needed for the Dashboard:
  
  - The placeholder is handled by the model which is a bit hackish, but this can mostly work for the new model as well by using the same offset-items-by-one trick used in the original model
  - The model can set the ordering for the items in it only when the item is there, so in order for this to work, the model needs to wait for the item to appear, and then move it to the desired position
  
  Both of these I have done, but that part is quite ugly. If this is considered a **necessary** feature, I can post the updated diff for review.

REVISION DETAIL
  https://phabricator.kde.org/D3805

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, mart, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

--1393aeaf1ac946dcbd0ed1f83c517593
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td style=3D"">ivan added a comment.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D3805" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><div><p>There are a few problems regarding the &#03=
9;drop&#039; placeholder needed for the Dashboard:</p>

<ul class=3D"remarkup-list">
<li class=3D"remarkup-list-item">The placeholder is handled by the model wh=
ich is a bit hackish, but this can mostly work for the new model as well by=
 using the same offset-items-by-one trick used in the original model</li>
<li class=3D"remarkup-list-item">The model can set the ordering for the ite=
ms in it only when the item is there, so in order for this to work, the mod=
el needs to wait for the item to appear, and then move it to the desired po=
sition</li>
</ul>

<p>Both of these I have done, but that part is quite ugly. If this is consi=
dered a <strong>necessary</strong> feature, I can post the updated diff for=
 review.</p></div></div><br /><div><strong>REVISION DETAIL</strong><div><a =
href=3D"https://phabricator.kde.org/D3805" rel=3D"noreferrer">https://phabr=
icator.kde.org/D3805</a></div></div><br /><div><strong>EMAIL PREFERENCES</s=
trong><div><a href=3D"https://phabricator.kde.org/settings/panel/emailprefe=
rences/" rel=3D"noreferrer">https://phabricator.kde.org/settings/panel/emai=
lpreferences/</a></div></div><br /><div><strong>To: </strong>ivan, mart, he=
in<br /><strong>Cc: </strong>plasma-devel, progwolff, lesliezhai, ali-moham=
ed, jensreuterberg, abetts, sebas, apol<br /></div>
--1393aeaf1ac946dcbd0ed1f83c517593--