[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 10 lines] D4845: Fix context menu button's icon size when on default DPI
From:       Chris Holland <noreply () phabricator ! kde ! org>
Date:       2017-02-28 17:41:27
Message-ID: differential-rev-PHID-DREV-4vr3wjjp3u2zumlrj4of-req () phabricator ! kde ! org
[Download RAW message or body]

Zren created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  ToolButton pads the contexts of the label+icon based on the desktop \
theme's svg margins. Causing the icon to only be 12px, which is scaled down \
and looks like a solid square with the breeze icon, as seen in \
https://phabricator.kde.org/D4751 comments. We want this button to be \
reasonably small, but should have the minimum of a 16px icon. The button \
itself is 18px atm. Since the icon doesn't go right to the edge, we can \
just overlay the icon on top of the button and apply all the \
ToolButtonStyle effects.

TEST PLAN
  Tested on 96 DPI and 2x DPI with:
  QT_DEVICE_PIXEL_RATIO=2 plasmoidviewer -a applet -l floating -f \
horizontal

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4845

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: Zren, subdiff, drosca, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">Zren created this revision.<br />Restricted \
Application added a project: Plasma.<br />Restricted Application added a \
subscriber: plasma-devel. </td><a style="text-decoration: none; padding: \
4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: \
bold; border-radius: 3px; background-color: #F7F7F9; background-image: \
linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px \
solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4845" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>ToolButton pads the contexts of the label+icon \
based on the desktop theme&#039;s svg margins. Causing the icon to only be \
12px, which is scaled down and looks like a solid square with the breeze \
icon, as seen in <a href="https://phabricator.kde.org/D4751" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;" \
rel="noreferrer">D4751</a> comments. We want this button to be reasonably \
small, but should have the minimum of a 16px icon. The button itself is \
18px atm. Since the icon doesn&#039;t go right to the edge, we can just \
overlay the icon on top of the button and apply all the ToolButtonStyle \
effects.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Tested \
on 96 DPI and 2x DPI with:<br /> QT_DEVICE_PIXEL_RATIO=2 plasmoidviewer -a \
applet -l floating -f horizontal</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume \
Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4845" \
rel="noreferrer">https://phabricator.kde.org/D4845</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>applet/contents/ui/ListItemBase.qml</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>Zren, subdiff, drosca, broulik<br /><strong>Cc: \
</strong>plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]