[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D4508: Plasma controls based on QtQuickControls2
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-02-28 15:51:21
Message-ID: 20170228155106.91778.8136.872C5F91 () phabricator ! kde ! org
[Download RAW message or body]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in Label.qml:27
> It probably made sense when it was written, but your comments about layouts is \
> outdated. 
> No manual changes are needed.
> 
> try:
> https://paste.kde.org/pgi2ui6e3
> 
> If it was a problem we'd be seeing it all the time in the config modules.
> 
> It is true for manual positioning and anchors, but I think the vast majority of the \
> time where we'd want to be aligned to a button we'd be in a layout with that \
> button. 
> I'm sure there will be some changes needed, but it'll be few. (if I remove the line \
> in my QQC1 label locally, I can't see any) 
> In constrast run this on your workspace folder:
> find -name '*.qml' | xargs grep 'height:' | grep  paintedHeight
> 
> and you'll see the number of times we have to reverse this logic.

so, GridLayout and RowLayout align correctly, while Row still doesn't.

so, ok for me to remove it, and require *layouts are used instead of simple \
positioners everywhere

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4508

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, broulik, plasma-devel, #frameworks, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4508" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D4508#inline-19572" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">davidedmundson</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">Label.qml:27</span></div> <div style="margin: 8px 0; padding: 0 12px; color: \
#74777D;"><p style="padding: 0; margin: 8px;">It probably made sense when it was \
written, but your comments about layouts is outdated.</p>

<p style="padding: 0; margin: 8px;">No manual changes are needed.</p>

<p style="padding: 0; margin: 8px;">try:<br />
<a href="https://paste.kde.org/pgi2ui6e3" class="remarkup-link" target="_blank" \
rel="noreferrer">https://paste.kde.org/pgi2ui6e3</a></p>

<p style="padding: 0; margin: 8px;">If it was a problem we&#039;d be seeing it all \
the time in the config modules.</p>

<p style="padding: 0; margin: 8px;">It is true for manual positioning and anchors, \
but I think the vast majority of the time where we&#039;d want to be aligned to a \
button we&#039;d be in a layout with that button.</p>

<p style="padding: 0; margin: 8px;">I&#039;m sure there will be some changes needed, \
but it&#039;ll be few. (if I remove the line in my QQC1 label locally, I can&#039;t \
see any)</p>

<p style="padding: 0; margin: 8px;">In constrast run this on your workspace \
folder:<br /> find -name &#039;*.qml&#039; | xargs grep &#039;height:&#039; | grep  \
paintedHeight</p>

<p style="padding: 0; margin: 8px;">and you&#039;ll see the number of times we have \
to reverse this logic.</p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">so, GridLayout and RowLayout align \
correctly, while Row still doesn&#039;t.</p>

<p style="padding: 0; margin: 8px;">so, ok for me to remove it, and require *layouts \
are used instead of simple positioners \
everywhere</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4508" \
rel="noreferrer">https://phabricator.kde.org/D4508</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>davidedmundson, \
broulik, plasma-devel, Frameworks, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]