--58b6fb2b425444d29d3d938dd271aa48
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in Label.qml:27
> It probably made sense when it was written, but your comments about layouts is outdated.
> 
> No manual changes are needed.
> 
> try:
> https://paste.kde.org/pgi2ui6e3
> 
> If it was a problem we'd be seeing it all the time in the config modules.
> 
> It is true for manual positioning and anchors, but I think the vast majority of the time where we'd want to be aligned to a button we'd be in a layout with that button.
> 
> I'm sure there will be some changes needed, but it'll be few. (if I remove the line in my QQC1 label locally, I can't see any)
> 
> In constrast run this on your workspace folder:
> find -name '*.qml' | xargs grep 'height:' | grep  paintedHeight
> 
> and you'll see the number of times we have to reverse this logic.

so, GridLayout and RowLayout align correctly, while Row still doesn't.

so, ok for me to remove it, and require *layouts are used instead of simple positioners everywhere

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4508

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, broulik, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

--58b6fb2b425444d29d3d938dd271aa48
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td style=3D"">mart added inline comments.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D4508" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style=3D"=
margin: 6px 0 12px 0;"><div style=3D"border: 1px solid #C7CCD9; border-radi=
us: 3px;"><div style=3D"padding: 0; background: #F7F7F7; border-color: #e3e=
4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style=
=3D"color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden=
;"><a style=3D"float: right; text-decoration: none;" href=3D"https://phabri=
cator.kde.org/D4508#inline-19572" rel=3D"noreferrer">View Inline</a><span s=
tyle=3D"color: #4b4d51; font-weight: bold;">davidedmundson</span> wrote in =
<span style=3D"color: #4b4d51; font-weight: bold;">Label.qml:27</span></div>
<div style=3D"margin: 8px 0; padding: 0 12px; color: #74777D;"><p style=3D"=
padding: 0; margin: 8px;">It probably made sense when it was written, but y=
our comments about layouts is outdated.</p>

<p style=3D"padding: 0; margin: 8px;">No manual changes are needed.</p>

<p style=3D"padding: 0; margin: 8px;">try:<br />
<a href=3D"https://paste.kde.org/pgi2ui6e3" class=3D"remarkup-link" target=
=3D"_blank" rel=3D"noreferrer">https://paste.kde.org/pgi2ui6e3</a></p>

<p style=3D"padding: 0; margin: 8px;">If it was a problem we&#039;d be seei=
ng it all the time in the config modules.</p>

<p style=3D"padding: 0; margin: 8px;">It is true for manual positioning and=
 anchors, but I think the vast majority of the time where we&#039;d want to=
 be aligned to a button we&#039;d be in a layout with that button.</p>

<p style=3D"padding: 0; margin: 8px;">I&#039;m sure there will be some chan=
ges needed, but it&#039;ll be few. (if I remove the line in my QQC1 label l=
ocally, I can&#039;t see any)</p>

<p style=3D"padding: 0; margin: 8px;">In constrast run this on your workspa=
ce folder:<br />
find -name &#039;*.qml&#039; | xargs grep &#039;height:&#039; | grep  paint=
edHeight</p>

<p style=3D"padding: 0; margin: 8px;">and you&#039;ll see the number of tim=
es we have to reverse this logic.</p></div></div>
<div style=3D"margin: 8px 0; padding: 0 12px;"><p style=3D"padding: 0; marg=
in: 8px;">so, GridLayout and RowLayout align correctly, while Row still doe=
sn&#039;t.</p>

<p style=3D"padding: 0; margin: 8px;">so, ok for me to remove it, and requi=
re *layouts are used instead of simple positioners everywhere</p></div></di=
v></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Pl=
asma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAI=
L</strong><div><a href=3D"https://phabricator.kde.org/D4508" rel=3D"norefer=
rer">https://phabricator.kde.org/D4508</a></div></div><br /><div><strong>EM=
AIL PREFERENCES</strong><div><a href=3D"https://phabricator.kde.org/setting=
s/panel/emailpreferences/" rel=3D"noreferrer">https://phabricator.kde.org/s=
ettings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </str=
ong>mart, Plasma<br /><strong>Cc: </strong>davidedmundson, broulik, plasma-=
devel, Frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet=
ts, sebas, apol<br /></div>
--58b6fb2b425444d29d3d938dd271aa48--