[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D4707: move setImagePath logic into updateFrameData()
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-02-28 11:57:52
Message-ID: 20170228115752.92987.82940.70F12562 () phabricator ! kde ! org
[Download RAW message or body]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in framesvg.cpp:804
> I don't understand this and the FrameData part of this change.
> 
> q->imagePath() will still always be correct as before, you still set that in \
> setImagePath() regardless of whether we are blocking updates or not.

i need this because one check, in updateFrameData() can have the following situation:

imagepath was updated during repaintBlocked, so q->imagePAth() becomes different from \
frameData->imagePath

from line 670 we temporarly assign the new values to framedata, so we can compare the \
two keys (we don't know which among enabledBorders, frameSize and imagePath changed, \
if any)

so i need to generate a cacheid with imagePath eventually in some cases different \
from q->imagePath()

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4707

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4707" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D4707#inline-19217" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">davidedmundson</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">framesvg.cpp:804</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">I don&#039;t understand this and \
the FrameData part of this change.</p>

<p style="padding: 0; margin: 8px;">q-&gt;imagePath() will still always be correct as \
before, you still set that in setImagePath() regardless of whether we are blocking \
updates or not.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">i need this because one check, in updateFrameData() \
can have the following situation:</p>

<p style="padding: 0; margin: 8px;">imagepath was updated during repaintBlocked, so \
q-&gt;imagePAth() becomes different from frameData-&gt;imagePath</p>

<p style="padding: 0; margin: 8px;">from line 670 we temporarly assign the new values \
to framedata, so we can compare the two keys (we don&#039;t know which among \
enabledBorders, frameSize and imagePath changed, if any)</p>

<p style="padding: 0; margin: 8px;">so i need to generate a cacheid with imagePath \
eventually in some cases different from \
q-&gt;imagePath()</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4707" \
rel="noreferrer">https://phabricator.kde.org/D4707</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>davidedmundson, \
plasma-devel, Frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]