[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D4739: make sure the cancel action is last
From:       David Faure <noreply () phabricator ! kde ! org>
Date:       2017-02-28 11:56:58
Message-ID: 20170228115654.121542.82553.F87750AC () phabricator ! kde ! org
[Download RAW message or body]

dfaure added inline comments.

INLINE COMMENTS

> mart wrote in dropjob.h:38
> used for class KIO::DropMenu : public QMenu in dropjob.cpp,
> doesn't compile otherwise

Not a good enough reason to have it in the public header (which doesn't use it \
anywhere), you can move that fwd decl to the .cpp file.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D4739

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #frameworks, dfaure
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol


[Attachment #3 (text/html)]

<table><tr><td style="">dfaure added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4739" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D4739#inline-19541" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">mart</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">dropjob.h:38</span></div> <div style="margin: 8px 0; padding: 0 12px; color: \
#74777D;"><p style="padding: 0; margin: 8px;">used for class KIO::DropMenu : public \
QMenu in dropjob.cpp,<br /> doesn&#039;t compile otherwise</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Not \
a good enough reason to have it in the public header (which doesn&#039;t use it \
anywhere), you can move that fwd decl to the .cpp \
file.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4739" \
rel="noreferrer">https://phabricator.kde.org/D4739</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma, Frameworks, dfaure<br /><strong>Cc: \
</strong>plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]