[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D4361: [Containment] Move contains() check inside NDEBUG
From:       Bhushan Shah <noreply () phabricator ! kde ! org>
Date:       2017-01-31 10:03:30
Message-ID: 20170131100330.106090.27263.9690FC92 () phabricator ! kde ! org
[Download RAW message or body]

bshah added a comment.


  I'd say we should port away all of the users of NDEBUG to qCDebug (if anything is \
still using qDebug) and remove those ifdefs..

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4361

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: bshah, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">bshah added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4361" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>I&#039;d say we should port away all of \
the users of NDEBUG to qCDebug (if anything is still using qDebug) and remove those \
ifdefs..</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma \
Framework (Library)</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a href="https://phabricator.kde.org/D4361" \
rel="noreferrer">https://phabricator.kde.org/D4361</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>bshah, \
plasma-devel, Frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]