[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 4 lines] D4361: [Containment] Move contains() check inside NDEBUG
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-01-31 9:58:12
Message-ID: differential-rev-PHID-DREV-ty44vxn5wlba7vbrzvcp-req () phabricator ! kde ! org
[Download RAW message or body]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Framework (Library).
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Since we don't return and only do something when NDEBUG is defined, don't do contains() for no reason.

TEST PLAN
  Not sure how useful this thing even is since the qCDebug inside the define is commented, even..

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4361

AFFECTED FILES
  src/plasma/containment.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Attachment #3 (text/html)]

<table><tr><td style="">broulik created this revision.<br />broulik added a reviewer: \
Plasma.<br />broulik set the repository for this revision to R242 Plasma Framework \
(Library).<br />Restricted Application added projects: Plasma, Frameworks.<br \
/>Restricted Application added subscribers: Frameworks, plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4361" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>Since we don&#039;t return and only do something when NDEBUG \
is defined, don&#039;t do contains() for no reason.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>Not sure how useful this thing even is since \
the qCDebug inside the define is commented, even..</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4361" \
rel="noreferrer">https://phabricator.kde.org/D4361</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/plasma/containment.cpp</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, \
Frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]