[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required
From: Ivan Čukić <ivan.cukic () kde ! org>
Date: 2017-01-15 18:47:37
Message-ID: 20170115184737.22235.90893 () mimi ! kde ! org
[Download RAW message or body]
--===============4000894489434234630==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129783/#review102051
-----------------------------------------------------------
Ship it!
Ship It!
- Ivan Čukić
On Jan. 15, 2017, 1:12 p.m., Andreas Sturmlechner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129783/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2017, 1:12 p.m.)
>
>
> Review request for Plasma, Ivan Čukić and Martin Koller.
>
>
> Repository: kio-extras
>
>
> Description
> -------
>
> 2 commits:
>
> - Make activities kioslave optional: Not everyone builds this for a Plasma desktop, \
> Qt5Sql is already only searched for in that subdirectory, so this gives some nice \
> modularity.
> - Make KF5Html dependency optional: only used by man
>
>
> Diffs
> -----
>
> CMakeLists.txt ba41101bb0cb247e55ded79224cd6bbbeb3f6b20
>
> Diff: https://git.reviewboard.kde.org/r/129783/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andreas Sturmlechner
>
>
--===============4000894489434234630==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129783/">https://git.reviewboard.kde.org/r/129783/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Ivan Čukić</p>
<br />
<p>On January 15th, 2017, 1:12 p.m. UTC, Andreas Sturmlechner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Ivan Čukić and Martin Koller.</div>
<div>By Andreas Sturmlechner.</div>
<p style="color: grey;"><i>Updated Jan. 15, 2017, 1:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">2 commits:</p> <ul style="padding: 0;text-rendering: \
inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;"> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Make activities kioslave optional: Not everyone builds this for a Plasma \
desktop, Qt5Sql is already only searched for in that subdirectory, so this gives some \
nice modularity.</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Make KF5Html dependency optional: only \
used by man</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(ba41101bb0cb247e55ded79224cd6bbbeb3f6b20)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129783/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4000894489434234630==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic