--===============4000894489434234630== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129783/#review102051 ----------------------------------------------------------- Ship it! Ship It! - Ivan Čukić On Jan. 15, 2017, 1:12 p.m., Andreas Sturmlechner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129783/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2017, 1:12 p.m.) > > > Review request for Plasma, Ivan Čukić and Martin Koller. > > > Repository: kio-extras > > > Description > ------- > > 2 commits: > > - Make activities kioslave optional: Not everyone builds this for a Plasma desktop, Qt5Sql is already only searched for in that subdirectory, so this gives some nice modularity. > - Make KF5Html dependency optional: only used by man > > > Diffs > ----- > > CMakeLists.txt ba41101bb0cb247e55ded79224cd6bbbeb3f6b20 > > Diff: https://git.reviewboard.kde.org/r/129783/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sturmlechner > > --===============4000894489434234630== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129783/

Ship it!

Ship It!

- Ivan Čukić


On January 15th, 2017, 1:12 p.m. UTC, Andreas Sturmlechner wrote:

Review request for Plasma, Ivan Čukić and Martin Koller.
By Andreas Sturmlechner.

Updated Jan. 15, 2017, 1:12 p.m.

Repository: kio-extras

Description

2 commits:

  • Make activities kioslave optional: Not everyone builds this for a Plasma desktop, Qt5Sql is already only searched for in that subdirectory, so this gives some nice modularity.
  • Make KF5Html dependency optional: only used by man

Diffs

  • CMakeLists.txt (ba41101bb0cb247e55ded79224cd6bbbeb3f6b20)

View Diff

--===============4000894489434234630==--