[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required
From: Andreas Sturmlechner <andreas.sturmlechner () gmail ! com>
Date: 2017-01-07 12:38:21
Message-ID: 20170107123821.13774.21267 () mimi ! kde ! org
[Download RAW message or body]
--===============7495131583271184573==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Jan. 7, 2017, 4:48 a.m., Anthony Fieroni wrote:
> > CMakeLists.txt, line 168
> > <https://git.reviewboard.kde.org/r/129783/diff/1/?file=488757#file488757line168>
> >
> > You still need find_package(KF5KHtml QUIET)
In the line above, but QUIET is indeed prettier, thanks.
- Andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129783/#review101846
-----------------------------------------------------------
On Jan. 7, 2017, 12:38 p.m., Andreas Sturmlechner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129783/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2017, 12:38 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kio-extras
>
>
> Description
> -------
>
> 2 commits:
>
> - Make activities kioslave optional: Not everyone builds this for a Plasma desktop, \
> Qt5Sql is already only searched for in that subdirectory, so this gives some nice \
> modularity.
> - Make KF5Html dependency optional: only used by man
>
>
> Diffs
> -----
>
> CMakeLists.txt ba41101bb0cb247e55ded79224cd6bbbeb3f6b20
>
> Diff: https://git.reviewboard.kde.org/r/129783/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andreas Sturmlechner
>
>
--===============7495131583271184573==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129783/">https://git.reviewboard.kde.org/r/129783/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 7th, 2017, 4:48 a.m. UTC, <b>Anthony \
Fieroni</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/129783/diff/1/?file=488757#file488757line168" \
style="color: black; font-weight: bold; text-decoration: \
underline;">CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">166</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
if(Gperf_FOUND AND KF5Html_FOUND)</pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
still need find_package(KF5KHtml QUIET)</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">In the line above, but QUIET is indeed prettier, thanks.</p></pre> <br />
<p>- Andreas</p>
<br />
<p>On January 7th, 2017, 12:38 p.m. UTC, Andreas Sturmlechner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Andreas Sturmlechner.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2017, 12:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">2 commits:</p> <ul style="padding: 0;text-rendering: \
inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;"> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Make activities kioslave optional: Not everyone builds this for a Plasma \
desktop, Qt5Sql is already only searched for in that subdirectory, so this gives some \
nice modularity.</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Make KF5Html dependency optional: only \
used by man</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(ba41101bb0cb247e55ded79224cd6bbbeb3f6b20)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129783/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7495131583271184573==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic