[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required
From:       Andreas Sturmlechner <andreas.sturmlechner () gmail ! com>
Date:       2017-01-07 12:38:12
Message-ID: 20170107123812.13774.35340 () mimi ! kde ! org
[Download RAW message or body]

--===============8886700495725536992==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129783/
-----------------------------------------------------------

(Updated Jan. 7, 2017, 12:38 p.m.)


Review request for Plasma.


Changes
-------

add QUIET to find_package call


Repository: kio-extras


Description
-------

2 commits:

- Make activities kioslave optional: Not everyone builds this for a Plasma desktop, \
Qt5Sql is already only searched for in that subdirectory, so this gives some nice \
                modularity.
- Make KF5Html dependency optional: only used by man


Diffs (updated)
-----

  CMakeLists.txt ba41101bb0cb247e55ded79224cd6bbbeb3f6b20 

Diff: https://git.reviewboard.kde.org/r/129783/diff/


Testing
-------


Thanks,

Andreas Sturmlechner


--===============8886700495725536992==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129783/">https://git.reviewboard.kde.org/r/129783/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Andreas Sturmlechner.</div>


<p style="color: grey;"><i>Updated Jan. 7, 2017, 12:38 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">add QUIET to find_package call</p></pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">2 commits:</p> <ul style="padding: 0;text-rendering: \
inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;"> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Make activities kioslave optional: Not everyone builds this for a Plasma \
desktop, Qt5Sql is already only searched for in that subdirectory, so this gives some \
nice modularity.</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Make KF5Html dependency optional: only \
used by man</li> </ul></pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(ba41101bb0cb247e55ded79224cd6bbbeb3f6b20)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129783/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============8886700495725536992==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic