[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D3870: [Converter Runner] Also convert to the user's local currency
From:       "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date:       2016-12-30 18:07:46
Message-ID: 20161230180746.26886.4699.0AA440DB () phabricator ! kde ! org
[Download RAW message or body]

broulik added a comment.


  > not units.prepend(localCurrency) so it's first?
  
  That's what I did originally but since we sort by magnitude/value at the end, the \
order would be lost eventually.  
  (Reviewboard manages to pick context from the repository, Phab only does so *after* \
having committed… I'll try the "-U" workaround, though)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3870

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: elvisangelaccio, subdiff, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3870" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>not units.prepend(localCurrency) so it&#039;s \
first?</p></blockquote>

<p>That&#039;s what I did originally but since we sort by magnitude/value at the end, \
the order would be lost eventually.</p>

<p>(Reviewboard manages to pick context from the repository, Phab only does so \
*after* having committed… I&#039;ll try the &quot;-U&quot; workaround, \
though)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R114 Plasma \
Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3870" \
rel="noreferrer">https://phabricator.kde.org/D3870</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, davidedmundson<br /><strong>Cc: \
</strong>elvisangelaccio, subdiff, davidedmundson, plasma-devel, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]