From kde-panel-devel  Fri Dec 30 18:07:46 2016
From: "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date: Fri, 30 Dec 2016 18:07:46 +0000
To: kde-panel-devel
Subject: [Differential] [Commented On] D3870: [Converter Runner] Also convert to the user's local currency
Message-Id: <20161230180746.26886.4699.0AA440DB () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=148312128226754
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--0dcca2a7d71d46b5b8ad7446e9954cc1"

--0dcca2a7d71d46b5b8ad7446e9954cc1
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

broulik added a comment.


  > not units.prepend(localCurrency) so it's first?
 =20
  That's what I did originally but since we sort by magnitude/value at the =
end, the order would be lost eventually.
 =20
  (Reviewboard manages to pick context from the repository, Phab only does =
so *after* having committed=E2=80=A6 I'll try the "-U" workaround, though)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3870

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: elvisangelaccio, subdiff, davidedmundson, plasma-devel, lesliezhai, ali=
-mohamed, jensreuterberg, abetts, sebas

--0dcca2a7d71d46b5b8ad7446e9954cc1
Content-Type: text/html; charset="utf-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td style=3D"">broulik added a comment.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D3870" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><div><blockquote style=3D"border-left: 3px solid #a=
7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4=
px 12px; background-color: #f8f9fc;"><p>not units.prepend(localCurrency) so=
 it&#039;s first?</p></blockquote>

<p>That&#039;s what I did originally but since we sort by magnitude/value a=
t the end, the order would be lost eventually.</p>

<p>(Reviewboard manages to pick context from the repository, Phab only does=
 so *after* having committed=E2=80=A6 I&#039;ll try the &quot;-U&quot; work=
around, though)</p></div></div><br /><div><strong>REPOSITORY</strong><div><=
div>R114 Plasma Addons</div></div></div><br /><div><strong>REVISION DETAIL<=
/strong><div><a href=3D"https://phabricator.kde.org/D3870" rel=3D"noreferre=
r">https://phabricator.kde.org/D3870</a></div></div><br /><div><strong>EMAI=
L PREFERENCES</strong><div><a href=3D"https://phabricator.kde.org/settings/=
panel/emailpreferences/" rel=3D"noreferrer">https://phabricator.kde.org/set=
tings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </stron=
g>broulik, Plasma, davidedmundson<br /><strong>Cc: </strong>elvisangelaccio=
, subdiff, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreute=
rberg, abetts, sebas<br /></div>
--0dcca2a7d71d46b5b8ad7446e9954cc1--