[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 9 lines] D3553: Fix 2 RTL bugs
From:       "ttv20 (Elkana Bardugo)" <noreply () phabricator ! kde ! org>
Date:       2016-11-30 21:56:20
Message-ID: differential-rev-PHID-DREV-rtc5wufjtzqpwjiuzks3-req () phabricator ! kde ! org
[Download RAW message or body]

ttv20 created this revision.
ttv20 added a reviewer: Plasma: Workspaces.
ttv20 set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Bug 364778: (DashboardRepresentation.qml)
  I add LayoutMirroring.
  
  Bug 372717:
  The kicker (Application menu) had special configuration - when the panel is on the right edge \
the layout is mirrored, because else the sidebar blocking the sub menus.  In RTL direction \
system this fix cause the search bar to overlap the sidebar.  So I Fix that and I add the same \
configuration for RTL direction system with left edge panel.

TEST PLAN
  I compiled from source and use it
  For the Application menu I check In RTL and LTR directions and check on all the edge and try \
to search something  All work fine.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3553

AFFECTED FILES
  applets/kicker/package/contents/ui/DashboardRepresentation.qml
  applets/kicker/package/contents/ui/MenuRepresentation.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ttv20, #plasma_workspaces
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">ttv20 created this revision.<br />ttv20 added a reviewer: Plasma: \
Workspaces.<br />ttv20 set the repository for this revision to R119 Plasma Desktop.<br \
/>Restricted Application added a project: Plasma.<br />Restricted Application added a \
subscriber: plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3553" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>Bug 364778: (DashboardRepresentation.qml)<br /> I add \
LayoutMirroring.</p>

<p>Bug 372717:<br />
The kicker (Application menu) had special configuration - when the panel is on the right edge \
the layout is mirrored, because else the sidebar blocking the sub menus.<br /> In RTL direction \
system this fix cause the search bar to overlap the sidebar.<br /> So I Fix that and I add the \
same configuration for RTL direction system with left edge panel.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>I compiled from source and use it<br /> For the \
Application menu I check In RTL and LTR directions and check on all the edge and try to search \
something<br /> All work fine.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3553" \
rel="noreferrer">https://phabricator.kde.org/D3553</a></div></div><br /><div><strong>AFFECTED \
FILES</strong><div><div>applets/kicker/package/contents/ui/DashboardRepresentation.qml<br /> \
applets/kicker/package/contents/ui/MenuRepresentation.qml</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>ttv20, Plasma: Workspaces<br /><strong>Cc: </strong>plasma-devel, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic