[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Accepted] D3479: [libinput] Add more support for touchpads in preparation for the ne
From: "davidedmundson (David Edmundson)" <noreply () phabricator ! kde ! org>
Date: 2016-11-30 16:44:24
Message-ID: 20161130164424.30766.92429.C9B43BDC () phabricator ! kde ! org
[Download RAW message or body]
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> connection.cpp:159
> QStringLiteral("notifyChange"), this, \
> SLOT(slotKGlobalSettingsNotifyChange(int,int)));
> -
> - QDBusConnection::sessionBus().registerService(s_serviceName);
> + QDBusConnection::sessionBus().registerObject(QStringLiteral("/org/kde/KWin/InputDeviceManager"),
> + \
> QStringLiteral("org.kde.KWin.InputDeviceManager"),
only other comment I did have
We have the path
/org/kde/KWin/InputDevice/event0
/org/kde/KWin/InputDevice/event1
...
I would put the manager interface on the path
/org/kde/KWin/InputDevice
so it reads like a tree.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D3479
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: subdiff, #kwin, #plasma, davidedmundson
Cc: graesslin, davidedmundson, plasma-devel, kwin, #kwin, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas
[Attachment #3 (text/html)]
<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson \
added a reviewer: davidedmundson.<br />davidedmundson added inline comments.<br \
/>This revision is now accepted and ready to land. </td><a style="text-decoration: \
none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: \
bold; border-radius: 3px; background-color: #F7F7F9; background-image: \
linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3479" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D3479#inline-13936" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">connection.cpp:159</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> \
<span class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"notifyChange"</span><span class="p">),</span> <span style="color: \
#aa4000">this</span><span class="p">,</span> <span class="n">SLOT</span><span \
class="p">(</span><span class="n">slotKGlobalSettingsNotifyChange</span><span \
class="p">(</span><span style="color: #aa4000">int</span><span \
class="p">,</span><span style="color: #aa4000">int</span><span class="p">)));</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span \
class="bright"></span><span class="n"><span \
class="bright">QDBusConnection</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">::</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">sessionBus</span></span><span class="bright"></span><span \
class="p"><span class="bright">().</span></span><span class="bright"></span><span \
class="n"><span class="bright">registerService</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">s_serviceName</span></span><span class="bright"></span><span \
class="p"><span class="bright">);</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"><span class="bright"> </span><span \
class="n"><span class="bright">QDBusConnection</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">::</span></span><span class="bright"></span><span class="n"><span \
class="bright">sessionBus</span></span><span class="bright"></span><span \
class="p"><span class="bright">().</span></span><span class="bright"></span><span \
class="n"><span class="bright">registerObject</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">QStringLiteral</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
style="color: #766510"><span \
class="bright">"/org/kde/KWin/InputDeviceManager"</span></span><span \
class="bright"></span><span class="p"><span class="bright">),</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="bright"> </span><span \
class="n"><span class="bright">QStringLiteral</span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span style="color: #766510"><span \
class="bright">"org.kde.KWin.InputDeviceManager"</span></span><span \
class="bright"></span><span class="p"><span class="bright">),</span></span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">only other comment I did have</p>
<p style="padding: 0; margin: 8px;">We have the path</p>
<p style="padding: 0; margin: 8px;">/org/kde/KWin/InputDevice/event0<br />
/org/kde/KWin/InputDevice/event1<br />
...</p>
<p style="padding: 0; margin: 8px;">I would put the manager interface on the path <br \
/>
/org/kde/KWin/InputDevice</p>
<p style="padding: 0; margin: 8px;">so it reads like a \
tree.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3479" \
rel="noreferrer">https://phabricator.kde.org/D3479</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>subdiff, KWin, Plasma, davidedmundson<br /><strong>Cc: \
</strong>graesslin, davidedmundson, plasma-devel, kwin, KWin, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic