From kde-panel-devel  Wed Nov 30 16:44:24 2016
From: "davidedmundson (David Edmundson)" <noreply () phabricator ! kde ! org>
Date: Wed, 30 Nov 2016 16:44:24 +0000
To: kde-panel-devel
Subject: [Differential] [Accepted] D3479: [libinput] Add more support for touchpads in preparation for the ne
Message-Id: <20161130164424.30766.92429.C9B43BDC () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=148052427823483
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--58a0c60f0e1148b4a22ff069838ba95e"

--58a0c60f0e1148b4a22ff069838ba95e
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> connection.cpp:159
>                                            QStringLiteral("notifyChange"), this, SLOT(slotKGlobalSettingsNotifyChange(int,int)));
> -
> -    QDBusConnection::sessionBus().registerService(s_serviceName);
> +    QDBusConnection::sessionBus().registerObject(QStringLiteral("/org/kde/KWin/InputDeviceManager"),
> +                                                 QStringLiteral("org.kde.KWin.InputDeviceManager"),

only other comment I did have

We have the path

/org/kde/KWin/InputDevice/event0
/org/kde/KWin/InputDevice/event1
...

I would put the manager interface on the path 
/org/kde/KWin/InputDevice

so it reads like a tree.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D3479

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #kwin, #plasma, davidedmundson
Cc: graesslin, davidedmundson, plasma-devel, kwin, #kwin, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

--58a0c60f0e1148b4a22ff069838ba95e
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td=20style=3D"">davidedmundson=20accepted=20this=20revision.<br=
=20/>davidedmundson=20added=20a=20reviewer:=20davidedmundson.<br=20/>davide=
dmundson=20added=20inline=20comments.<br=20/>This=20revision=20is=20now=20a=
ccepted=20and=20ready=20to=20land.
</td><a=20style=3D"text-decoration:=20none;=20padding:=204px=208px;=20margi=
n:=200=208px=208px;=20float:=20right;=20color:=20#464C5C;=20font-weight:=20=
bold;=20border-radius:=203px;=20background-color:=20#F7F7F9;=20background-i=
mage:=20linear-gradient(to=20bottom,#fff,#f1f0f1);=20display:=20inline-bloc=
k;=20border:=201px=20solid=20rgba(71,87,120,.2);"=20href=3D"https://phabric=
ator.kde.org/D3479"=20rel=3D"noreferrer">View=20Revision</a></tr></table><b=
r=20/><div><strong>INLINE=20COMMENTS</strong><div><div=20style=3D"margin:=
=206px=200=2012px=200;"><div=20style=3D"border:=201px=20solid=20#C7CCD9;=20=
border-radius:=203px;"><div=20style=3D"padding:=200;=20background:=20#F7F7F=
7;=20border-color:=20#e3e4e8;=20border-style:=20solid;=20border-width:=200=
=200=201px=200;=20margin:=200;"><div=20style=3D"color:=20#74777d;=20backgro=
und:=20#eff2f4;=20padding:=206px=208px;=20overflow:=20hidden;"><a=20style=
=3D"float:=20right;=20text-decoration:=20none;"=20href=3D"https://phabricat=
or.kde.org/D3479#inline-13936"=20rel=3D"noreferrer">View=20Inline</a><span=
=20style=3D"color:=20#4b4d51;=20font-weight:=20bold;">connection.cpp:159</s=
pan></div>
<div=20style=3D"font:=2011px/15px=20&quot;Menlo&quot;,=20&quot;Consolas&quo=
t;,=20&quot;Monaco&quot;,=20monospace;=20white-space:=20pre-wrap;=20clear:=
=20both;=20padding:=204px=200;=20margin:=200;"><div=20style=3D"padding:=200=
=208px;=20margin:=200=204px;=20">=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20<span=20class=3D"n">QStringLiteral</span><span=20class=3D"p">(</sp=
an><span=20style=3D"color:=20#766510">&quot;notifyChange&quot;</span><span=
=20class=3D"p">),</span>=20<span=20style=3D"color:=20#aa4000">this</span><s=
pan=20class=3D"p">,</span>=20<span=20class=3D"n">SLOT</span><span=20class=
=3D"p">(</span><span=20class=3D"n">slotKGlobalSettingsNotifyChange</span><s=
pan=20class=3D"p">(</span><span=20style=3D"color:=20#aa4000">int</span><spa=
n=20class=3D"p">,</span><span=20style=3D"color:=20#aa4000">int</span><span=
=20class=3D"p">)));</span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#ffd0d0;">
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#ffd0d0;">=20=20=20=20<span=20class=3D"bright"></span><span=20class=3D"=
n"><span=20class=3D"bright">QDBusConnection</span></span><span=20class=3D"b=
right"></span><span=20style=3D"color:=20#aa2211"><span=20class=3D"bright">:=
:</span></span><span=20class=3D"bright"></span><span=20class=3D"n"><span=20=
class=3D"bright">sessionBus</span></span><span=20class=3D"bright"></span><s=
pan=20class=3D"p"><span=20class=3D"bright">().</span></span><span=20class=
=3D"bright"></span><span=20class=3D"n"><span=20class=3D"bright">registerSer=
vice</span></span><span=20class=3D"bright"></span><span=20class=3D"p"><span=
=20class=3D"bright">(</span></span><span=20class=3D"bright"></span><span=20=
class=3D"n"><span=20class=3D"bright">s_serviceName</span></span><span=20cla=
ss=3D"bright"></span><span=20class=3D"p"><span=20class=3D"bright">);</span>=
</span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;"><span=20class=3D"bright">=20=20=20=20</span><span=20class=3D"=
n"><span=20class=3D"bright">QDBusConnection</span></span><span=20class=3D"b=
right"></span><span=20style=3D"color:=20#aa2211"><span=20class=3D"bright">:=
:</span></span><span=20class=3D"bright"></span><span=20class=3D"n"><span=20=
class=3D"bright">sessionBus</span></span><span=20class=3D"bright"></span><s=
pan=20class=3D"p"><span=20class=3D"bright">().</span></span><span=20class=
=3D"bright"></span><span=20class=3D"n"><span=20class=3D"bright">registerObj=
ect</span></span><span=20class=3D"bright"></span><span=20class=3D"p"><span=
=20class=3D"bright">(</span></span><span=20class=3D"bright"></span><span=20=
class=3D"n"><span=20class=3D"bright">QStringLiteral</span></span><span=20cl=
ass=3D"bright"></span><span=20class=3D"p"><span=20class=3D"bright">(</span>=
</span><span=20class=3D"bright"></span><span=20style=3D"color:=20#766510"><=
span=20class=3D"bright">&quot;/org/kde/KWin/InputDeviceManager&quot;</span>=
</span><span=20class=3D"bright"></span><span=20class=3D"p"><span=20class=3D=
"bright">),</span></span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20<span=20class=3D"bright">=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20</span><span=20class=3D"n"><span=20clas=
s=3D"bright">QStringLiteral</span></span><span=20class=3D"bright"></span><s=
pan=20class=3D"p"><span=20class=3D"bright">(</span></span><span=20class=3D"=
bright"></span><span=20style=3D"color:=20#766510"><span=20class=3D"bright">=
&quot;org.kde.KWin.InputDeviceManager&quot;</span></span><span=20class=3D"b=
right"></span><span=20class=3D"p"><span=20class=3D"bright">),</span></span>
</div></div></div>
<div=20style=3D"margin:=208px=200;=20padding:=200=2012px;"><p=20style=3D"pa=
dding:=200;=20margin:=208px;">only=20other=20comment=20I=20did=20have</p>

<p=20style=3D"padding:=200;=20margin:=208px;">We=20have=20the=20path</p>

<p=20style=3D"padding:=200;=20margin:=208px;">/org/kde/KWin/InputDevice/eve=
nt0<br=20/>
/org/kde/KWin/InputDevice/event1<br=20/>
...</p>

<p=20style=3D"padding:=200;=20margin:=208px;">I=20would=20put=20the=20manag=
er=20interface=20on=20the=20path=20<br=20/>
/org/kde/KWin/InputDevice</p>

<p=20style=3D"padding:=200;=20margin:=208px;">so=20it=20reads=20like=20a=20=
tree.</p></div></div></div></div></div><br=20/><div><strong>REPOSITORY</str=
ong><div><div>R108=20KWin</div></div></div><br=20/><div><strong>REVISION=20=
DETAIL</strong><div><a=20href=3D"https://phabricator.kde.org/D3479"=20rel=
=3D"noreferrer">https://phabricator.kde.org/D3479</a></div></div><br=20/><d=
iv><strong>EMAIL=20PREFERENCES</strong><div><a=20href=3D"https://phabricato=
r.kde.org/settings/panel/emailpreferences/"=20rel=3D"noreferrer">https://ph=
abricator.kde.org/settings/panel/emailpreferences/</a></div></div><br=20/><=
div><strong>To:=20</strong>subdiff,=20KWin,=20Plasma,=20davidedmundson<br=
=20/><strong>Cc:=20</strong>graesslin,=20davidedmundson,=20plasma-devel,=20=
kwin,=20KWin,=20lesliezhai,=20ali-mohamed,=20jensreuterberg,=20abetts,=20se=
bas<br=20/></div>
--58a0c60f0e1148b4a22ff069838ba95e--