[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Changed Subscribers] D3192: The combobox needs to be 2 pixels wider for contents to 
From:       "davidedmundson (David Edmundson)" <noreply () phabricator ! kde ! org>
Date:       2016-10-31 16:16:25
Message-ID: 20161031161625.3171.14726.F9992204 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added inline comments.

INLINE COMMENTS

> breezestyle.cpp:2507
>          // make sure there is enough height for the button
>          size.setHeight( qMax( size.height(), int(Metrics::MenuButton_IndicatorWidth) ) );
>  

you're still basing the height off the MenuButton_IndicatorWidth which you're otherwise not using

Is that intentional?

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3192

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antlarr, #plasma, #plasma:_design
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, htietze, sebas

[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3192" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D3192#inline-12477" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">breezestyle.cpp:2507</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; ">        // make sure there is enough height for the button \
</div><div style="padding: 0 8px; margin: 0 4px; ">        size.setHeight( qMax( \
size.height(), int(Metrics::MenuButton_IndicatorWidth) ) ); </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">you&#039;re still basing the height off the MenuButton_IndicatorWidth which \
you&#039;re otherwise not using</p>

<p style="padding: 0; margin: 8px;">Is that \
intentional?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rBREEZE Breeze</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3192" \
rel="noreferrer">https://phabricator.kde.org/D3192</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>antlarr, Plasma, Plasma: Design<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, htietze, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]