[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Changed Subscribers] D3188: Modified distance function to keep aspect ratio as close
From: "mart (Marco Martin)" <noreply () phabricator ! kde ! org>
Date: 2016-10-28 14:24:23
Message-ID: 20161028142423.76782.94588.F551FD11 () phabricator ! kde ! org
[Download RAW message or body]
mart added inline comments.
INLINE COMMENTS
> image.cpp:186
>
> - //qDebug() << "wanted" << m_targetSize << "options" << images;
> -
> - // choose the nearest resolution, always preferring images with the same \
> aspect ratio + //float targetAspectRatio = (m_targetSize.height() > 0 ) ? \
> m_targetSize.width() / (float)m_targetSize.height() : 0; + //qDebug() << \
> "wanted" << m_targetSize << "options" << images << "aspect ratio" << \
> targetAspectRatio;
remove dead code
> image.cpp:196
> }
> - float candidateAspectRatio = candidate.width()/(float)candidate.height();
> + //float candidateAspectRatio = (candidate.height() > 0 ) ? \
> candidate.width() / (float)candidate.height() : FLT_MAX;
dead code
> testfindpreferredimage.cpp:90
> + total++;
> + if (preferred != expected) failed++;
> + std::cout << "For a screen size of " << qPrintable(formatResolution(resolution))
good that a test has been added!
but instead of doing all of this manually, couldn't it use qt autotest stuff, \
qcompare, qtest etc?
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3188
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: antlarr, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Attachment #3 (text/html)]
<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3188" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D3188#inline-12391" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">image.cpp:186</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #ffd0d0;"> <span style="color: #74777d">//<span \
class="bright">qDebug() << "wanted" << m_targetSize << \
"options" << images</span>;</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #ffd0d0;"> </div><div style="padding: 0 8px; margin: 0 \
4px; background: #ffd0d0;"> <span style="color: #74777d">// choose the nearest \
resolution, always preferring images with the same aspect ratio</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: \
#74777d">//<span class="bright">float targetAspectRatio = (m_targetSize.height() > \
0 ) ? m_targetSize.width() / (float)m_targetSize.height() : 0</span>;</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span \
class="bright"> </span><span style="color: #74777d"><span \
class="bright">//qDebug() << "wanted" << m_targetSize << \
"options" << images << "aspect ratio" << \
targetAspectRatio;</span></span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">remove dead code</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D3188#inline-12392" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">image.cpp:196</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> \
<span class="p">}</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#ffd0d0;"> <span class="bright"></span><span style="color: #aa4000"><span \
class="bright">float</span></span><span class="bright"> </span><span class="n"><span \
class="bright">candidateAspectRatio</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> \
</span><span class="n"><span class="bright">candidate</span></span><span \
class="bright"></span><span class="p"><span class="bright">.</span></span><span \
class="bright"></span><span class="n"><span class="bright">width</span></span><span \
class="bright"></span><span class="p"><span class="bright">()</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">/</span></span><span class="bright"></span><span class="p"><span \
class="bright">(</span></span><span class="bright"></span><span style="color: \
#aa4000"><span class="bright">float</span></span><span class="bright"></span><span \
class="p"><span class="bright">)</span></span><span class="bright"></span><span \
class="n"><span class="bright">candidate</span></span><span \
class="bright"></span><span class="p"><span class="bright">.</span></span><span \
class="bright"></span><span class="n"><span class="bright">height</span></span><span \
class="bright"></span><span class="p"><span class="bright">()</span>;</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="bright"></span><span style="color: #74777d"><span class="bright">//float \
candidateAspectRatio = (candidate.height() > 0 ) ? candidate.width() / \
(float)candidate.height() : FLT_MAX</span>;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">dead \
code</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D3188#inline-12397" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">testfindpreferredimage.cpp:90</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span class="n">total</span><span \
style="color: #aa2211">++</span><span class="p">;</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">if</span> \
<span class="p">(</span><span class="n">preferred</span> <span style="color: \
#aa2211">!=</span> <span class="n">expected</span><span class="p">)</span> <span \
class="n">failed</span><span style="color: #aa2211">++</span><span class="p">;</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="n">std</span><span style="color: #aa2211">::</span><span class="n">cout</span> \
<span style="color: #aa2211"><<</span> <span style="color: #766510">"For a \
screen size of "</span> <span style="color: #aa2211"><<</span> <span \
class="n">qPrintable</span><span class="p">(</span><span \
class="n">formatResolution</span><span class="p">(</span><span \
class="n">resolution</span><span class="p">))</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">good \
that a test has been added!<br /> but instead of doing all of this manually, \
couldn't it use qt autotest stuff, qcompare, qtest \
etc?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3188" \
rel="noreferrer">https://phabricator.kde.org/D3188</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>antlarr, Plasma<br /><strong>Cc: </strong>mart, \
plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic