[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Updated, 2,678 lines] D3086: Clean up KAppMenu
From:       "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date:       2016-10-31 15:55:13
Message-ID: 20161031155508.3243.19268.41A907DC () phabricator ! kde ! org
[Download RAW message or body]

broulik retitled this revision from "RFC: Clean up KAppMenu" to "Clean up KAppMenu".
broulik updated the test plan for this revision.
broulik updated this revision to Diff 7784.
broulik added a comment.


  - Cache atom to avoid roundtrip to the x server
  - Add "reconfigured" signal so interested parties (like KWin) get notified when the app menu config changes
  - Drop Gtk Icons mapping - it's not like GTK would support DBusMenu anymore anyway...

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3086?vs=7727&id=7784

REVISION DETAIL
  https://phabricator.kde.org/D3086

AFFECTED FILES
  appmenu/CMakeLists.txt
  appmenu/appmenu.cpp
  appmenu/appmenu.h
  appmenu/appmenu_dbus.cpp
  appmenu/appmenu_dbus.h
  appmenu/glowbar.cpp
  appmenu/glowbar.h
  appmenu/gtkicons.h
  appmenu/kdbusimporter.h
  appmenu/menubar.cpp
  appmenu/menubar.h
  appmenu/menubutton.cpp
  appmenu/menubutton.h
  appmenu/menuimporter.cpp
  appmenu/menuimporter.h
  appmenu/menuwidget.cpp
  appmenu/menuwidget.h
  appmenu/org.kde.kappmenu.xml
  appmenu/shadows.cpp
  appmenu/shadows.h
  appmenu/topmenubar.cpp
  appmenu/topmenubar.h
  appmenu/verticalmenu.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Attachment #3 (text/html)]

<table><tr><td style="">broulik retitled this revision from &quot;RFC: Clean up KAppMenu&quot; to \
&quot;Clean up KAppMenu&quot;.<br />broulik updated the test plan for this revision. <a \
href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-qehk6zuv72t7lf3/" \
rel="noreferrer">(Show Details)</a><br />broulik updated this revision to Diff 7784.<br />broulik added a \
comment. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: \
#464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: \
linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3086" rel="noreferrer">View Revision</a></tr></table><br \
/><div><div><ul class="remarkup-list"> <li class="remarkup-list-item">Cache atom to avoid roundtrip to \
the x server</li> <li class="remarkup-list-item">Add &quot;reconfigured&quot; signal so interested \
parties (like KWin) get notified when the app menu config changes</li> <li \
class="remarkup-list-item">Drop Gtk Icons mapping - it&#039;s not like GTK would support DBusMenu anymore \
anyway...</li> </ul></div></div><br /><div><strong>EDIT DETAILS</strong><div><div style="white-space: \
pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>    Style=<span style="padding: 0 2px; \
color: #802b2b; background: rgba(251, 175, 175, .7);">ButtonVertical</span><span style="padding: 0 2px; \
color: #3e6d35; background: rgba(151, 234, 151, .6);">Decoration</span><br /> <br />
Applications like Kwrite, Dolphin, as well as VLC start exporting their manus on DBus now. The \
&quot;showMenu&quot; method on the org.kde.kappmenu dbus interface can be used to show the application \
menu. The menu button also shows up for Chrome and Firefox.<div style="padding: 8px \
0;">...</div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a \
href="https://phabricator.kde.org/D3086?vs=7727&amp;id=7784" \
rel="noreferrer">https://phabricator.kde.org/D3086?vs=7727&amp;id=7784</a></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3086" \
rel="noreferrer">https://phabricator.kde.org/D3086</a></div></div><br /><div><strong>AFFECTED \
FILES</strong><div><div>appmenu/CMakeLists.txt<br /> appmenu/appmenu.cpp<br />
appmenu/appmenu.h<br />
appmenu/appmenu_dbus.cpp<br />
appmenu/appmenu_dbus.h<br />
appmenu/glowbar.cpp<br />
appmenu/glowbar.h<br />
appmenu/gtkicons.h<br />
appmenu/kdbusimporter.h<br />
appmenu/menubar.cpp<br />
appmenu/menubar.h<br />
appmenu/menubutton.cpp<br />
appmenu/menubutton.h<br />
appmenu/menuimporter.cpp<br />
appmenu/menuimporter.h<br />
appmenu/menuwidget.cpp<br />
appmenu/menuwidget.h<br />
appmenu/org.kde.kappmenu.xml<br />
appmenu/shadows.cpp<br />
appmenu/shadows.h<br />
appmenu/topmenubar.cpp<br />
appmenu/topmenubar.h<br />
appmenu/verticalmenu.h</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, mart<br /><strong>Cc: </strong>graesslin, plasma-devel, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]