--a62f3d7ff78c425aa09432f784c45568
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

broulik retitled this revision from "RFC: Clean up KAppMenu" to "Clean up KAppMenu".
broulik updated the test plan for this revision.
broulik updated this revision to Diff 7784.
broulik added a comment.


  - Cache atom to avoid roundtrip to the x server
  - Add "reconfigured" signal so interested parties (like KWin) get notified when the app menu config changes
  - Drop Gtk Icons mapping - it's not like GTK would support DBusMenu anymore anyway...

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3086?vs=7727&id=7784

REVISION DETAIL
  https://phabricator.kde.org/D3086

AFFECTED FILES
  appmenu/CMakeLists.txt
  appmenu/appmenu.cpp
  appmenu/appmenu.h
  appmenu/appmenu_dbus.cpp
  appmenu/appmenu_dbus.h
  appmenu/glowbar.cpp
  appmenu/glowbar.h
  appmenu/gtkicons.h
  appmenu/kdbusimporter.h
  appmenu/menubar.cpp
  appmenu/menubar.h
  appmenu/menubutton.cpp
  appmenu/menubutton.h
  appmenu/menuimporter.cpp
  appmenu/menuimporter.h
  appmenu/menuwidget.cpp
  appmenu/menuwidget.h
  appmenu/org.kde.kappmenu.xml
  appmenu/shadows.cpp
  appmenu/shadows.h
  appmenu/topmenubar.cpp
  appmenu/topmenubar.h
  appmenu/verticalmenu.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

--a62f3d7ff78c425aa09432f784c45568
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td=20style=3D"">broulik=20retitled=20this=20revision=20from=20&=
quot;RFC:=20Clean=20up=20KAppMenu&quot;=20to=20&quot;Clean=20up=20KAppMenu&=
quot;.<br=20/>broulik=20updated=20the=20test=20plan=20for=20this=20revision=
.=20<a=20href=3D"https://phabricator.kde.org/transactions/detail/PHID-XACT-=
DREV-qehk6zuv72t7lf3/"=20rel=3D"noreferrer">(Show=20Details)</a><br=20/>bro=
ulik=20updated=20this=20revision=20to=20Diff=207784.<br=20/>broulik=20added=
=20a=20comment.
</td><a=20style=3D"text-decoration:=20none;=20padding:=204px=208px;=20margi=
n:=200=208px=208px;=20float:=20right;=20color:=20#464C5C;=20font-weight:=20=
bold;=20border-radius:=203px;=20background-color:=20#F7F7F9;=20background-i=
mage:=20linear-gradient(to=20bottom,#fff,#f1f0f1);=20display:=20inline-bloc=
k;=20border:=201px=20solid=20rgba(71,87,120,.2);"=20href=3D"https://phabric=
ator.kde.org/D3086"=20rel=3D"noreferrer">View=20Revision</a></tr></table><b=
r=20/><div><div><ul=20class=3D"remarkup-list">
<li=20class=3D"remarkup-list-item">Cache=20atom=20to=20avoid=20roundtrip=20=
to=20the=20x=20server</li>
<li=20class=3D"remarkup-list-item">Add=20&quot;reconfigured&quot;=20signal=
=20so=20interested=20parties=20(like=20KWin)=20get=20notified=20when=20the=
=20app=20menu=20config=20changes</li>
<li=20class=3D"remarkup-list-item">Drop=20Gtk=20Icons=20mapping=20-=20it&#0=
39;s=20not=20like=20GTK=20would=20support=20DBusMenu=20anymore=20anyway...<=
/li>
</ul></div></div><br=20/><div><strong>EDIT=20DETAILS</strong><div><div=20st=
yle=3D"white-space:=20pre-wrap;=20color:=20#74777D;"><div=20style=3D"paddin=
g:=208px=200;">...</div>=20=20=20=20Style=3D<span=20style=3D"padding:=200=
=202px;=20color:=20#802b2b;=20background:=20rgba(251,=20175,=20175,=20.7);"=
>ButtonVertical</span><span=20style=3D"padding:=200=202px;=20color:=20#3e6d=
35;=20background:=20rgba(151,=20234,=20151,=20.6);">Decoration</span><br=20=
/>
<br=20/>
Applications=20like=20Kwrite,=20Dolphin,=20as=20well=20as=20VLC=20start=20e=
xporting=20their=20manus=20on=20DBus=20now.=20The=20&quot;showMenu&quot;=20=
method=20on=20the=20org.kde.kappmenu=20dbus=20interface=20can=20be=20used=
=20to=20show=20the=20application=20menu.=20The=20menu=20button=20also=20sho=
ws=20up=20for=20Chrome=20and=20Firefox.<div=20style=3D"padding:=208px=200;"=
>...</div></div></div></div><br=20/><div><strong>REPOSITORY</strong><div><d=
iv>rPLASMAWORKSPACE=20Plasma=20Workspace</div></div></div><br=20/><div><str=
ong>CHANGES=20SINCE=20LAST=20UPDATE</strong><div><a=20href=3D"https://phabr=
icator.kde.org/D3086?vs=3D7727&amp;id=3D7784"=20rel=3D"noreferrer">https://=
phabricator.kde.org/D3086?vs=3D7727&amp;id=3D7784</a></div></div><br=20/><d=
iv><strong>REVISION=20DETAIL</strong><div><a=20href=3D"https://phabricator.=
kde.org/D3086"=20rel=3D"noreferrer">https://phabricator.kde.org/D3086</a></=
div></div><br=20/><div><strong>AFFECTED=20FILES</strong><div><div>appmenu/C=
MakeLists.txt<br=20/>
appmenu/appmenu.cpp<br=20/>
appmenu/appmenu.h<br=20/>
appmenu/appmenu_dbus.cpp<br=20/>
appmenu/appmenu_dbus.h<br=20/>
appmenu/glowbar.cpp<br=20/>
appmenu/glowbar.h<br=20/>
appmenu/gtkicons.h<br=20/>
appmenu/kdbusimporter.h<br=20/>
appmenu/menubar.cpp<br=20/>
appmenu/menubar.h<br=20/>
appmenu/menubutton.cpp<br=20/>
appmenu/menubutton.h<br=20/>
appmenu/menuimporter.cpp<br=20/>
appmenu/menuimporter.h<br=20/>
appmenu/menuwidget.cpp<br=20/>
appmenu/menuwidget.h<br=20/>
appmenu/org.kde.kappmenu.xml<br=20/>
appmenu/shadows.cpp<br=20/>
appmenu/shadows.h<br=20/>
appmenu/topmenubar.cpp<br=20/>
appmenu/topmenubar.h<br=20/>
appmenu/verticalmenu.h</div></div></div><br=20/><div><strong>EMAIL=20PREFER=
ENCES</strong><div><a=20href=3D"https://phabricator.kde.org/settings/panel/=
emailpreferences/"=20rel=3D"noreferrer">https://phabricator.kde.org/setting=
s/panel/emailpreferences/</a></div></div><br=20/><div><strong>To:=20</stron=
g>broulik,=20Plasma,=20mart<br=20/><strong>Cc:=20</strong>graesslin,=20plas=
ma-devel,=20lesliezhai,=20ali-mohamed,=20jensreuterberg,=20abetts,=20sebas<=
br=20/></div>
--a62f3d7ff78c425aa09432f784c45568--