[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Changed Subscribers] D3212: Support drags from Widget Explorer onto System Tray
From:       "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date:       2016-10-31 13:04:06
Message-ID: 20161031130400.34761.72231.ADA9A348 () phabricator ! kde ! org
[Download RAW message or body]

broulik added inline comments.

INLINE COMMENTS

> main.qml:241
> +        onDragEnter: {
> +            if (event.mimeData.formats.indexOf("text/x-plasmoidservicename") < 0) {
> +                event.ignore();

Can you split that into a function so we then have

  onDragEnter: {
      if (!isAcceptableDragEvent(event)) {
          event.ignore()
          return
      }
  }
  onDrop: {
      if (!isAcceptableDragEvent(event)) {
          event.ignore()
          return
      }
      ...
  }

> systemtray.h:100
>  
> +    Q_INVOKABLE bool isSystemTrayApplet(const QString &appletId);
> +

const

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3212

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Attachment #3 (text/html)]

<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3212" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D3212#inline-12453" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">main.qml:241</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;">        <span style="color: #aa4000">onDragEnter:</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#d0ffd0;">            <span style="color: #aa4000">if</span> <span \
class="p">(</span><span style="color: #004012">event</span><span \
class="p">.</span><span style="color: #004012">mimeData</span><span \
class="p">.</span><span style="color: #004012">formats</span><span \
class="p">.</span><span style="color: #004012">indexOf</span><span \
class="p">(</span><span style="color: \
#766510">&quot;text/x-plasmoidservicename&quot;</span><span class="p">)</span> <span \
style="color: #aa2211">&lt;</span> <span style="color: #601200">0</span><span \
class="p">)</span> <span class="p">{</span> </div><div style="padding: 0 8px; margin: \
0 4px; background: #d0ffd0;">                <span style="color: \
#004012">event</span><span class="p">.</span><span style="color: \
#004012">ignore</span><span class="p">();</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can \
you split that into a function so we then have</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">onDragEnter: {  if \
(!isAcceptableDragEvent(event)) {  event.ignore()
        return
    }
}
onDrop: {
    if (!isAcceptableDragEvent(event)) {
        event.ignore()
        return
    }
    ...
}</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D3212#inline-12455" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">systemtray.h:100</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;">    <span class="n">Q_INVOKABLE</span> <span style="color: \
#aa4000">bool</span> <span style="color: #004012">isSystemTrayApplet</span><span \
class="p">(</span><span style="color: #aa4000">const</span> <span \
class="n">QString</span> <span style="color: #aa2211">&amp;</span><span \
class="n">appletId</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">const</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3212" \
rel="noreferrer">https://phabricator.kde.org/D3212</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>broulik, \
plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]