--9627d0acdbf94eb98ba8b97011d34403
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

broulik added inline comments.

INLINE COMMENTS

> main.qml:241
> +        onDragEnter: {
> +            if (event.mimeData.formats.indexOf("text/x-plasmoidservicename") < 0) {
> +                event.ignore();

Can you split that into a function so we then have

  onDragEnter: {
      if (!isAcceptableDragEvent(event)) {
          event.ignore()
          return
      }
  }
  onDrop: {
      if (!isAcceptableDragEvent(event)) {
          event.ignore()
          return
      }
      ...
  }

> systemtray.h:100
>  
> +    Q_INVOKABLE bool isSystemTrayApplet(const QString &appletId);
> +

const

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3212

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

--9627d0acdbf94eb98ba8b97011d34403
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td=20style=3D"">broulik=20added=20inline=20comments.
</td><a=20style=3D"text-decoration:=20none;=20padding:=204px=208px;=20margi=
n:=200=208px=208px;=20float:=20right;=20color:=20#464C5C;=20font-weight:=20=
bold;=20border-radius:=203px;=20background-color:=20#F7F7F9;=20background-i=
mage:=20linear-gradient(to=20bottom,#fff,#f1f0f1);=20display:=20inline-bloc=
k;=20border:=201px=20solid=20rgba(71,87,120,.2);"=20href=3D"https://phabric=
ator.kde.org/D3212"=20rel=3D"noreferrer">View=20Revision</a></tr></table><b=
r=20/><div><strong>INLINE=20COMMENTS</strong><div><div=20style=3D"margin:=
=206px=200=2012px=200;"><div=20style=3D"border:=201px=20solid=20#C7CCD9;=20=
border-radius:=203px;"><div=20style=3D"padding:=200;=20background:=20#F7F7F=
7;=20border-color:=20#e3e4e8;=20border-style:=20solid;=20border-width:=200=
=200=201px=200;=20margin:=200;"><div=20style=3D"color:=20#74777d;=20backgro=
und:=20#eff2f4;=20padding:=206px=208px;=20overflow:=20hidden;"><a=20style=
=3D"float:=20right;=20text-decoration:=20none;"=20href=3D"https://phabricat=
or.kde.org/D3212#inline-12453"=20rel=3D"noreferrer">View=20Inline</a><span=
=20style=3D"color:=20#4b4d51;=20font-weight:=20bold;">main.qml:241</span></=
div>
<div=20style=3D"font:=2011px/15px=20&quot;Menlo&quot;,=20&quot;Consolas&quo=
t;,=20&quot;Monaco&quot;,=20monospace;=20white-space:=20pre-wrap;=20clear:=
=20both;=20padding:=204px=200;=20margin:=200;"><div=20style=3D"padding:=200=
=208px;=20margin:=200=204px;=20background:=20#d0ffd0;">=20=20=20=20=20=20=
=20=20<span=20style=3D"color:=20#aa4000">onDragEnter:</span>=20<span=20clas=
s=3D"p">{</span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20=20=20=20=20=20=20=20=20<span=20style=3D"color:=
=20#aa4000">if</span>=20<span=20class=3D"p">(</span><span=20style=3D"color:=
=20#004012">event</span><span=20class=3D"p">.</span><span=20style=3D"color:=
=20#004012">mimeData</span><span=20class=3D"p">.</span><span=20style=3D"col=
or:=20#004012">formats</span><span=20class=3D"p">.</span><span=20style=3D"c=
olor:=20#004012">indexOf</span><span=20class=3D"p">(</span><span=20style=3D=
"color:=20#766510">&quot;text/x-plasmoidservicename&quot;</span><span=20cla=
ss=3D"p">)</span>=20<span=20style=3D"color:=20#aa2211">&lt;</span>=20<span=
=20style=3D"color:=20#601200">0</span><span=20class=3D"p">)</span>=20<span=
=20class=3D"p">{</span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20<span=20style=
=3D"color:=20#004012">event</span><span=20class=3D"p">.</span><span=20style=
=3D"color:=20#004012">ignore</span><span=20class=3D"p">();</span>
</div></div></div>
<div=20style=3D"margin:=208px=200;=20padding:=200=2012px;"><p=20style=3D"pa=
dding:=200;=20margin:=208px;">Can=20you=20split=20that=20into=20a=20functio=
n=20so=20we=20then=20have</p>

<div=20class=3D"remarkup-code-block"=20style=3D"margin:=2012px=200;"=20data=
-code-lang=3D"text"=20data-sigil=3D"remarkup-code-block"><pre=20class=3D"re=
markup-code"=20style=3D"font:=2011px/15px=20&quot;Menlo&quot;,=20&quot;Cons=
olas&quot;,=20&quot;Monaco&quot;,=20monospace;=20padding:=2012px;=20margin:=
=200;=20background:=20rgba(71,=2087,=20120,=200.08);">onDragEnter:=20{
=20=20=20=20if=20(!isAcceptableDragEvent(event))=20{
=20=20=20=20=20=20=20=20event.ignore()
=20=20=20=20=20=20=20=20return
=20=20=20=20}
}
onDrop:=20{
=20=20=20=20if=20(!isAcceptableDragEvent(event))=20{
=20=20=20=20=20=20=20=20event.ignore()
=20=20=20=20=20=20=20=20return
=20=20=20=20}
=20=20=20=20...
}</pre></div></div></div><br=20/><div=20style=3D"border:=201px=20solid=20#C=
7CCD9;=20border-radius:=203px;"><div=20style=3D"padding:=200;=20background:=
=20#F7F7F7;=20border-color:=20#e3e4e8;=20border-style:=20solid;=20border-wi=
dth:=200=200=201px=200;=20margin:=200;"><div=20style=3D"color:=20#74777d;=
=20background:=20#eff2f4;=20padding:=206px=208px;=20overflow:=20hidden;"><a=
=20style=3D"float:=20right;=20text-decoration:=20none;"=20href=3D"https://p=
habricator.kde.org/D3212#inline-12455"=20rel=3D"noreferrer">View=20Inline</=
a><span=20style=3D"color:=20#4b4d51;=20font-weight:=20bold;">systemtray.h:1=
00</span></div>
<div=20style=3D"font:=2011px/15px=20&quot;Menlo&quot;,=20&quot;Consolas&quo=
t;,=20&quot;Monaco&quot;,=20monospace;=20white-space:=20pre-wrap;=20clear:=
=20both;=20padding:=204px=200;=20margin:=200;"><div=20style=3D"padding:=200=
=208px;=20margin:=200=204px;=20background:=20#d0ffd0;">=20=20=20=20<span=20=
class=3D"n">Q_INVOKABLE</span>=20<span=20style=3D"color:=20#aa4000">bool</s=
pan>=20<span=20style=3D"color:=20#004012">isSystemTrayApplet</span><span=20=
class=3D"p">(</span><span=20style=3D"color:=20#aa4000">const</span>=20<span=
=20class=3D"n">QString</span>=20<span=20style=3D"color:=20#aa2211">&amp;</s=
pan><span=20class=3D"n">appletId</span><span=20class=3D"p">);</span>
</div></div></div>
<div=20style=3D"margin:=208px=200;=20padding:=200=2012px;"><p=20style=3D"pa=
dding:=200;=20margin:=208px;">const</p></div></div></div></div></div><br=20=
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE=20Plasma=20Wor=
kspace</div></div></div><br=20/><div><strong>REVISION=20DETAIL</strong><div=
><a=20href=3D"https://phabricator.kde.org/D3212"=20rel=3D"noreferrer">https=
://phabricator.kde.org/D3212</a></div></div><br=20/><div><strong>EMAIL=20PR=
EFERENCES</strong><div><a=20href=3D"https://phabricator.kde.org/settings/pa=
nel/emailpreferences/"=20rel=3D"noreferrer">https://phabricator.kde.org/set=
tings/panel/emailpreferences/</a></div></div><br=20/><div><strong>To:=20</s=
trong>davidedmundson,=20Plasma<br=20/><strong>Cc:=20</strong>broulik,=20pla=
sma-devel,=20lesliezhai,=20ali-mohamed,=20jensreuterberg,=20abetts,=20sebas=
<br=20/></div>
--9627d0acdbf94eb98ba8b97011d34403--