[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Changed Subscribers] D2900: [Kickoff] Draw FrameSvgItem behind kickoff configuration
From:       "davidedmundson (David Edmundson)" <noreply () phabricator ! kde ! org>
Date:       2016-09-30 21:03:34
Message-ID: 20160930210334.5140.13467.BC95EA57 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added inline comments.

INLINE COMMENTS

> KickoffConfigurationButton.qml:30-38
> +        width: units.gridUnit * 6
> +        height: units.gridUnit * 5
> 
> -    property alias icon: iconElement.source
> -    property alias text: textElement.text
> -    property string name
> 
> -    width: units.gridUnit * 6
> -    height: units.gridUnit * 5
> +    PlasmaCore.FrameSvgItem {
> +        id: container
> +        width: units.gridUnit * 6

You should be able to get rid of the Item {} and just use the FrameSvgItem \
for the root component

> KickoffConfigurationButton.qml:45
> 
> -        height: childrenRect.height
> +        imagePath: plasmoid.location === PlasmaCore.Types.Vertical || \
> plasmoid.location === PlasmaCore.Types.Horizontal +                ? \
> "widgets/panel-background" : "widgets/background"

for the tabs the background will always be widgets/background they're not \
shown directly on the panel.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2900

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2900" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: \
0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; \
border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D2900#inline-11253" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">KickoffConfigurationButton.qml:30-38</span></div> <div style="font: \
11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: \
0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    \
<span class="bright"></span><span style="color: #aa4000"><span \
class="bright">visible:</span></span><span class="bright"> </span><span \
style="color: #004012"><span class="bright">name</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">!=</span></span><span class="bright"> </span><span \
style="color: #766510"><span class="bright">&quot;empty&quot;</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    \
<span class="bright">    </span><span style="color: #aa4000"><span \
class="bright">width:</span></span><span class="bright"> </span><span \
style="color: #004012"><span class="bright">units</span></span><span \
class="bright"></span><span class="p"><span \
class="bright">.</span></span><span class="bright"></span><span \
style="color: #004012"><span class="bright">gridUnit</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">*</span></span><span class="bright"> </span><span \
style="color: #601200"><span class="bright">6</span></span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span \
style="color: #aa4000">height:</span> <span style="color: \
#004012">units</span><span class="p">.</span><span style="color: \
#004012">gridUnit</span> <span style="color: #aa2211">*</span> <span \
style="color: #601200">5</span> </div><div style="padding: 0 8px; margin: 0 \
4px; "> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#ffd0d0;">    <span style="color: #004012">property</span> <span \
style="color: #004012">alias</span> <span style="color: \
#aa4000">icon:</span> <span style="color: #004012">iconElement</span><span \
class="p">.</span><span style="color: #004012">source</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span \
style="color: #004012">property</span> <span style="color: \
#004012">alias</span> <span style="color: #aa4000">text:</span> <span \
style="color: #004012">textElement</span><span class="p">.</span><span \
style="color: #004012">text</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #ffd0d0;">    <span style="color: \
#004012">property</span> <span style="color: #004012">string</span> <span \
style="color: #004012">name</span> </div><div style="padding: 0 8px; \
margin: 0 4px; "> </div><div style="padding: 0 8px; margin: 0 4px; \
background: #ffd0d0;">    <span class="bright"></span><span style="color: \
#aa4000"><span class="bright">width:</span></span><span class="bright"> \
</span><span style="color: #004012"><span \
class="bright">units</span></span><span class="bright"></span><span \
class="p"><span class="bright">.</span></span><span \
class="bright"></span><span style="color: #004012"><span \
class="bright">gridUnit</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">*</span></span><span \
class="bright"> </span><span style="color: #601200"><span \
class="bright">6</span></span> </div><div style="padding: 0 8px; margin: 0 \
4px; background: #ffd0d0;">    <span class="bright"></span><span \
style="color: #aa4000"><span class="bright">height:</span></span><span \
class="bright"> </span><span style="color: #004012"><span \
class="bright">units</span></span><span class="bright"></span><span \
class="p"><span class="bright">.</span></span><span \
class="bright"></span><span style="color: #004012"><span \
class="bright">gridUnit</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">*</span></span><span \
class="bright"> </span><span style="color: #601200"><span \
class="bright">5</span></span> </div><div style="padding: 0 8px; margin: 0 \
4px; background: #d0ffd0;">    <span class="bright"></span><span \
style="color: #004012"><span class="bright">PlasmaCore</span></span><span \
class="bright"></span><span class="p"><span \
class="bright">.</span></span><span class="bright"></span><span \
style="color: #004012"><span class="bright">FrameSvgItem</span></span><span \
class="bright"> </span><span class="p"><span class="bright">{</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    \
<span class="bright">    </span><span style="color: #aa4000"><span \
class="bright">id: container</span></span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: \
#aa4000">width:</span> <span style="color: #004012">units</span><span \
class="p">.</span><span style="color: #004012">gridUnit</span> <span \
style="color: #aa2211">*</span> <span style="color: #601200">6</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">You should be able to get rid of the Item \
{} and just use the FrameSvgItem for the root component</p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div \
style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: \
hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D2900#inline-11255" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">KickoffConfigurationButton.qml:45</span></div> <div style="font: \
11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: \
0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">       \
<span class="bright"></span><span style="color: #aa4000"><span \
class="bright">height:</span></span><span class="bright"> </span><span \
style="color: #004012"><span class="bright">childrenRect</span></span><span \
class="bright"></span><span class="p"><span \
class="bright">.</span></span><span class="bright"></span><span \
style="color: #004012"><span class="bright">height</span></span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span \
class="bright"></span><span style="color: #aa4000"><span \
class="bright">imagePath:</span></span><span class="bright"> </span><span \
style="color: #004012"><span class="bright">plasmoid</span></span><span \
class="bright"></span><span class="p"><span \
class="bright">.</span></span><span class="bright"></span><span \
style="color: #004012"><span class="bright">location</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">===</span></span><span class="bright"> </span><span \
style="color: #004012"><span class="bright">PlasmaCore</span></span><span \
class="bright"></span><span class="p"><span \
class="bright">.</span></span><span class="bright"></span><span \
style="color: #004012"><span class="bright">Types</span></span><span \
class="bright"></span><span class="p"><span \
class="bright">.</span></span><span class="bright"></span><span \
style="color: #004012"><span class="bright">Vertical</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">||</span></span><span class="bright"> </span><span \
style="color: #004012"><span class="bright">plasmoid</span></span><span \
class="bright"></span><span class="p"><span \
class="bright">.</span></span><span class="bright"></span><span \
style="color: #004012"><span class="bright">location</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">===</span></span><span class="bright"> </span><span \
style="color: #004012"><span class="bright">PlasmaCore</span></span><span \
class="bright"></span><span class="p"><span \
class="bright">.</span></span><span class="bright"></span><span \
style="color: #004012"><span class="bright">Types</span></span><span \
class="bright"></span><span class="p"><span \
class="bright">.</span></span><span class="bright"></span><span \
style="color: #004012"><span class="bright">Horizontal</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">     \
<span style="color: #aa2211">?</span> <span style="color: \
#766510">&quot;widgets/panel-background&quot;</span> <span style="color: \
#aa2211">:</span> <span style="color: \
#766510">&quot;widgets/background&quot;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">for the tabs the background will always be widgets/background \
they&#039;re not shown directly on the \
panel.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2900" \
rel="noreferrer">https://phabricator.kde.org/D2900</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>jsalatas, Plasma, Plasma: Design<br \
/><strong>Cc: </strong>davidedmundson, plasma-devel, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]