--721ef3d208b04a88bc0d9832faa2d7e3
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

davidedmundson added inline comments.

INLINE COMMENTS

> KickoffConfigurationButton.qml:30-38
> +        width: units.gridUnit * 6
> +        height: units.gridUnit * 5
>  
> -    property alias icon: iconElement.source
> -    property alias text: textElement.text
> -    property string name
>  
> -    width: units.gridUnit * 6
> -    height: units.gridUnit * 5
> +    PlasmaCore.FrameSvgItem {
> +        id: container
> +        width: units.gridUnit * 6

You should be able to get rid of the Item {} and just use the FrameSvgItem for the root component

> KickoffConfigurationButton.qml:45
>  
> -        height: childrenRect.height
> +        imagePath: plasmoid.location === PlasmaCore.Types.Vertical || plasmoid.location === PlasmaCore.Types.Horizontal
> +                ? "widgets/panel-background" : "widgets/background"

for the tabs the background will always be widgets/background they're not shown directly on the panel.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2900

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

--721ef3d208b04a88bc0d9832faa2d7e3
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td=20style=3D"">davidedmundson=20added=20inline=20comments.
</td><a=20style=3D"text-decoration:=20none;=20padding:=204px=208px;=20margi=
n:=200=208px=208px;=20float:=20right;=20color:=20#464C5C;=20font-weight:=20=
bold;=20border-radius:=203px;=20background-color:=20#F7F7F9;=20background-i=
mage:=20linear-gradient(to=20bottom,#fff,#f1f0f1);=20display:=20inline-bloc=
k;=20border:=201px=20solid=20rgba(71,87,120,.2);"=20href=3D"https://phabric=
ator.kde.org/D2900"=20rel=3D"noreferrer">View=20Revision</a></tr></table><b=
r=20/><div><strong>INLINE=20COMMENTS</strong><div><div=20style=3D"margin:=
=206px=200=2012px=200;"><div=20style=3D"border:=201px=20solid=20#C7CCD9;=20=
border-radius:=203px;"><div=20style=3D"padding:=200;=20background:=20#F7F7F=
7;=20border-color:=20#e3e4e8;=20border-style:=20solid;=20border-width:=200=
=200=201px=200;=20margin:=200;"><div=20style=3D"color:=20#74777d;=20backgro=
und:=20#eff2f4;=20padding:=206px=208px;=20overflow:=20hidden;"><a=20style=
=3D"float:=20right;=20text-decoration:=20none;"=20href=3D"https://phabricat=
or.kde.org/D2900#inline-11253"=20rel=3D"noreferrer">View=20Inline</a><span=
=20style=3D"color:=20#4b4d51;=20font-weight:=20bold;">KickoffConfigurationB=
utton.qml:30-38</span></div>
<div=20style=3D"font:=2011px/15px=20&quot;Menlo&quot;,=20&quot;Consolas&quo=
t;,=20&quot;Monaco&quot;,=20monospace;=20white-space:=20pre-wrap;=20clear:=
=20both;=20padding:=204px=200;=20margin:=200;"><div=20style=3D"padding:=200=
=208px;=20margin:=200=204px;=20background:=20#ffd0d0;">=20=20=20=20<span=20=
class=3D"bright"></span><span=20style=3D"color:=20#aa4000"><span=20class=3D=
"bright">visible:</span></span><span=20class=3D"bright">=20</span><span=20s=
tyle=3D"color:=20#004012"><span=20class=3D"bright">name</span></span><span=
=20class=3D"bright">=20</span><span=20style=3D"color:=20#aa2211"><span=20cl=
ass=3D"bright">!=3D</span></span><span=20class=3D"bright">=20</span><span=
=20style=3D"color:=20#766510"><span=20class=3D"bright">&quot;empty&quot;</s=
pan></span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20<span=20class=3D"bright">=20=20=20=20</span><span=
=20style=3D"color:=20#aa4000"><span=20class=3D"bright">width:</span></span>=
<span=20class=3D"bright">=20</span><span=20style=3D"color:=20#004012"><span=
=20class=3D"bright">units</span></span><span=20class=3D"bright"></span><spa=
n=20class=3D"p"><span=20class=3D"bright">.</span></span><span=20class=3D"br=
ight"></span><span=20style=3D"color:=20#004012"><span=20class=3D"bright">gr=
idUnit</span></span><span=20class=3D"bright">=20</span><span=20style=3D"col=
or:=20#aa2211"><span=20class=3D"bright">*</span></span><span=20class=3D"bri=
ght">=20</span><span=20style=3D"color:=20#601200"><span=20class=3D"bright">=
6</span></span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20=20=20=20=20<span=20style=3D"color:=20#aa4000">he=
ight:</span>=20<span=20style=3D"color:=20#004012">units</span><span=20class=
=3D"p">.</span><span=20style=3D"color:=20#004012">gridUnit</span>=20<span=
=20style=3D"color:=20#aa2211">*</span>=20<span=20style=3D"color:=20#601200"=
>5</span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20">
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#ffd0d0;">=20=20=20=20<span=20style=3D"color:=20#004012">property</span=
>=20<span=20style=3D"color:=20#004012">alias</span>=20<span=20style=3D"colo=
r:=20#aa4000">icon:</span>=20<span=20style=3D"color:=20#004012">iconElement=
</span><span=20class=3D"p">.</span><span=20style=3D"color:=20#004012">sourc=
e</span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#ffd0d0;">=20=20=20=20<span=20style=3D"color:=20#004012">property</span=
>=20<span=20style=3D"color:=20#004012">alias</span>=20<span=20style=3D"colo=
r:=20#aa4000">text:</span>=20<span=20style=3D"color:=20#004012">textElement=
</span><span=20class=3D"p">.</span><span=20style=3D"color:=20#004012">text<=
/span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#ffd0d0;">=20=20=20=20<span=20style=3D"color:=20#004012">property</span=
>=20<span=20style=3D"color:=20#004012">string</span>=20<span=20style=3D"col=
or:=20#004012">name</span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20">
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#ffd0d0;">=20=20=20=20<span=20class=3D"bright"></span><span=20style=3D"=
color:=20#aa4000"><span=20class=3D"bright">width:</span></span><span=20clas=
s=3D"bright">=20</span><span=20style=3D"color:=20#004012"><span=20class=3D"=
bright">units</span></span><span=20class=3D"bright"></span><span=20class=3D=
"p"><span=20class=3D"bright">.</span></span><span=20class=3D"bright"></span=
><span=20style=3D"color:=20#004012"><span=20class=3D"bright">gridUnit</span=
></span><span=20class=3D"bright">=20</span><span=20style=3D"color:=20#aa221=
1"><span=20class=3D"bright">*</span></span><span=20class=3D"bright">=20</sp=
an><span=20style=3D"color:=20#601200"><span=20class=3D"bright">6</span></sp=
an>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#ffd0d0;">=20=20=20=20<span=20class=3D"bright"></span><span=20style=3D"=
color:=20#aa4000"><span=20class=3D"bright">height:</span></span><span=20cla=
ss=3D"bright">=20</span><span=20style=3D"color:=20#004012"><span=20class=3D=
"bright">units</span></span><span=20class=3D"bright"></span><span=20class=
=3D"p"><span=20class=3D"bright">.</span></span><span=20class=3D"bright"></s=
pan><span=20style=3D"color:=20#004012"><span=20class=3D"bright">gridUnit</s=
pan></span><span=20class=3D"bright">=20</span><span=20style=3D"color:=20#aa=
2211"><span=20class=3D"bright">*</span></span><span=20class=3D"bright">=20<=
/span><span=20style=3D"color:=20#601200"><span=20class=3D"bright">5</span><=
/span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20<span=20class=3D"bright"></span><span=20style=3D"=
color:=20#004012"><span=20class=3D"bright">PlasmaCore</span></span><span=20=
class=3D"bright"></span><span=20class=3D"p"><span=20class=3D"bright">.</spa=
n></span><span=20class=3D"bright"></span><span=20style=3D"color:=20#004012"=
><span=20class=3D"bright">FrameSvgItem</span></span><span=20class=3D"bright=
">=20</span><span=20class=3D"p"><span=20class=3D"bright">{</span></span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20<span=20class=3D"bright">=20=20=20=20</span><span=
=20style=3D"color:=20#aa4000"><span=20class=3D"bright">id:=20container</spa=
n></span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20=20=20=20=20<span=20style=3D"color:=20#aa4000">wi=
dth:</span>=20<span=20style=3D"color:=20#004012">units</span><span=20class=
=3D"p">.</span><span=20style=3D"color:=20#004012">gridUnit</span>=20<span=
=20style=3D"color:=20#aa2211">*</span>=20<span=20style=3D"color:=20#601200"=
>6</span>
</div></div></div>
<div=20style=3D"margin:=208px=200;=20padding:=200=2012px;"><p=20style=3D"pa=
dding:=200;=20margin:=208px;">You=20should=20be=20able=20to=20get=20rid=20o=
f=20the=20Item=20{}=20and=20just=20use=20the=20FrameSvgItem=20for=20the=20r=
oot=20component</p></div></div><br=20/><div=20style=3D"border:=201px=20soli=
d=20#C7CCD9;=20border-radius:=203px;"><div=20style=3D"padding:=200;=20backg=
round:=20#F7F7F7;=20border-color:=20#e3e4e8;=20border-style:=20solid;=20bor=
der-width:=200=200=201px=200;=20margin:=200;"><div=20style=3D"color:=20#747=
77d;=20background:=20#eff2f4;=20padding:=206px=208px;=20overflow:=20hidden;=
"><a=20style=3D"float:=20right;=20text-decoration:=20none;"=20href=3D"https=
://phabricator.kde.org/D2900#inline-11255"=20rel=3D"noreferrer">View=20Inli=
ne</a><span=20style=3D"color:=20#4b4d51;=20font-weight:=20bold;">KickoffCon=
figurationButton.qml:45</span></div>
<div=20style=3D"font:=2011px/15px=20&quot;Menlo&quot;,=20&quot;Consolas&quo=
t;,=20&quot;Monaco&quot;,=20monospace;=20white-space:=20pre-wrap;=20clear:=
=20both;=20padding:=204px=200;=20margin:=200;"><div=20style=3D"padding:=200=
=208px;=20margin:=200=204px;=20background:=20#ffd0d0;">=20=20=20=20=20=20=
=20=20<span=20class=3D"bright"></span><span=20style=3D"color:=20#aa4000"><s=
pan=20class=3D"bright">height:</span></span><span=20class=3D"bright">=20</s=
pan><span=20style=3D"color:=20#004012"><span=20class=3D"bright">childrenRec=
t</span></span><span=20class=3D"bright"></span><span=20class=3D"p"><span=20=
class=3D"bright">.</span></span><span=20class=3D"bright"></span><span=20sty=
le=3D"color:=20#004012"><span=20class=3D"bright">height</span></span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20=20=20=20=20<span=20class=3D"bright"></span><span=
=20style=3D"color:=20#aa4000"><span=20class=3D"bright">imagePath:</span></s=
pan><span=20class=3D"bright">=20</span><span=20style=3D"color:=20#004012"><=
span=20class=3D"bright">plasmoid</span></span><span=20class=3D"bright"></sp=
an><span=20class=3D"p"><span=20class=3D"bright">.</span></span><span=20clas=
s=3D"bright"></span><span=20style=3D"color:=20#004012"><span=20class=3D"bri=
ght">location</span></span><span=20class=3D"bright">=20</span><span=20style=
=3D"color:=20#aa2211"><span=20class=3D"bright">=3D=3D=3D</span></span><span=
=20class=3D"bright">=20</span><span=20style=3D"color:=20#004012"><span=20cl=
ass=3D"bright">PlasmaCore</span></span><span=20class=3D"bright"></span><spa=
n=20class=3D"p"><span=20class=3D"bright">.</span></span><span=20class=3D"br=
ight"></span><span=20style=3D"color:=20#004012"><span=20class=3D"bright">Ty=
pes</span></span><span=20class=3D"bright"></span><span=20class=3D"p"><span=
=20class=3D"bright">.</span></span><span=20class=3D"bright"></span><span=20=
style=3D"color:=20#004012"><span=20class=3D"bright">Vertical</span></span><=
span=20class=3D"bright">=20</span><span=20style=3D"color:=20#aa2211"><span=
=20class=3D"bright">||</span></span><span=20class=3D"bright">=20</span><spa=
n=20style=3D"color:=20#004012"><span=20class=3D"bright">plasmoid</span></sp=
an><span=20class=3D"bright"></span><span=20class=3D"p"><span=20class=3D"bri=
ght">.</span></span><span=20class=3D"bright"></span><span=20style=3D"color:=
=20#004012"><span=20class=3D"bright">location</span></span><span=20class=3D=
"bright">=20</span><span=20style=3D"color:=20#aa2211"><span=20class=3D"brig=
ht">=3D=3D=3D</span></span><span=20class=3D"bright">=20</span><span=20style=
=3D"color:=20#004012"><span=20class=3D"bright">PlasmaCore</span></span><spa=
n=20class=3D"bright"></span><span=20class=3D"p"><span=20class=3D"bright">.<=
/span></span><span=20class=3D"bright"></span><span=20style=3D"color:=20#004=
012"><span=20class=3D"bright">Types</span></span><span=20class=3D"bright"><=
/span><span=20class=3D"p"><span=20class=3D"bright">.</span></span><span=20c=
lass=3D"bright"></span><span=20style=3D"color:=20#004012"><span=20class=3D"=
bright">Horizontal</span></span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20<span=20style=
=3D"color:=20#aa2211">?</span>=20<span=20style=3D"color:=20#766510">&quot;w=
idgets/panel-background&quot;</span>=20<span=20style=3D"color:=20#aa2211">:=
</span>=20<span=20style=3D"color:=20#766510">&quot;widgets/background&quot;=
</span>
</div></div></div>
<div=20style=3D"margin:=208px=200;=20padding:=200=2012px;"><p=20style=3D"pa=
dding:=200;=20margin:=208px;">for=20the=20tabs=20the=20background=20will=20=
always=20be=20widgets/background=20they&#039;re=20not=20shown=20directly=20=
on=20the=20panel.</p></div></div></div></div></div><br=20/><div><strong>REP=
OSITORY</strong><div><div>rPLASMADESKTOP=20Plasma=20Desktop</div></div></di=
v><br=20/><div><strong>REVISION=20DETAIL</strong><div><a=20href=3D"https://=
phabricator.kde.org/D2900"=20rel=3D"noreferrer">https://phabricator.kde.org=
/D2900</a></div></div><br=20/><div><strong>EMAIL=20PREFERENCES</strong><div=
><a=20href=3D"https://phabricator.kde.org/settings/panel/emailpreferences/"=
=20rel=3D"noreferrer">https://phabricator.kde.org/settings/panel/emailprefe=
rences/</a></div></div><br=20/><div><strong>To:=20</strong>jsalatas,=20Plas=
ma,=20Plasma:=20Design<br=20/><strong>Cc:=20</strong>davidedmundson,=20plas=
ma-devel,=20lesliezhai,=20ali-mohamed,=20jensreuterberg,=20abetts,=20sebas<=
br=20/></div>
--721ef3d208b04a88bc0d9832faa2d7e3--